Skip to content

Optical sim/reco updates#892

Draft
mvicenzi wants to merge 37 commits intofeature/mvicenzi_repro_step1from
feature/pmtsim_gain
Draft

Optical sim/reco updates#892
mvicenzi wants to merge 37 commits intofeature/mvicenzi_repro_step1from
feature/pmtsim_gain

Conversation

@mvicenzi
Copy link
Copy Markdown
Member

@mvicenzi mvicenzi commented Apr 1, 2026 •
edited
Loading

This PR contains additional updates to the optical sim/reco flow on top of #876 .
In particular:

  • introduced new PMT channel status/voltage database for both detsim and stage0
  • introduced new interface to the PMT gain database in detsim for MC-overlays
  • switched optical reconstruction entry point to local module
  • re-tuned flash PE thresholds based on new PE scale
  • added optional debug tree in optical detsim module
  • updated FHiCLs for database use in MC-overlays/data (fixed/constant values still used for legacy MC)

This PR requires two icarus_data updates:

  • pmt_speareas_data.db to v1r2
  • pmt_voltage_data.db to v1r3

mvicenzi added 30 commits January 13, 2026 12:32
@mvicenzi
tentative debug tree
f4545fe
@mvicenzi
tweaks for success build
64a3304
@mvicenzi
move to other loop
2dda045
@mvicenzi
save debug only with photons
0bd7e74
@mvicenzi
store photon start position in debug
fc5e966
@mvicenzi
remove old variables
69c8e17
@mvicenzi
remove forgotten variable
e490f27
@mvicenzi
augment gain db service
f2ddbc9
@mvicenzi
add gain service provider interface
a7bb214
@mvicenzi
fix linking for db interface
60fc035
@mvicenzi
update speareas database tag
384a5ef
@mvicenzi
add pmt channel status service
213b9e0
@mvicenzi
tie up the service
ee0f6af
@mvicenzi
fix linking
be29f41
@mvicenzi
change kOn to kGood
a47faad
@mvicenzi
use channel status service in pmtsim
27c3dea
@mvicenzi
update fcls for legacy vs overlay flow
4245aa2
@mvicenzi
switch reco to local entry point
8203c27
@mvicenzi
fix sharing factory with ped algos
ca85cc3
@mvicenzi
fix standard calibrator + add channel status service
f457297
@mvicenzi
remove conflicting defaults
617b74c
@mvicenzi
remove mcophit from mc-overlays
66fda19
@mvicenzi
never hold service pointers, you fool
a6a4bcf
@mvicenzi
expose integral and bias from sampled waveform tool
bd7dd28
@mvicenzi
plug in db gain and spread in simulation
2192b3b
@mvicenzi
fix variable name
46f9ef6
@mvicenzi
keep database use false for default non-overlay MC
206283c
@mvicenzi
add forgotten service
09cb33c
@mvicenzi
improve prints
cb07257
@mvicenzi
better printing
37ffe21
@mvicenzi mvicenzi self-assigned this Apr 1, 2026
@mvicenzi mvicenzi added the enhancement New feature or request label Apr 1, 2026
@mvicenzi mvicenzi linked an issue Apr 1, 2026 that may be closed by this pull request
Update the PMT dead/noisy channel list #708
Open
@mvicenzi mvicenzi mentioned this pull request Apr 1, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mvicenzi mvicenzi

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update the PMT dead/noisy channel list

1 participant

@mvicenzi