Add support for additional display modes#1602
Add support for additional display modes#1602falbrechtskirchinger wants to merge 1 commit intoReturn-To-The-Roots:masterfrom
Conversation
|
@Spikeone There you go! |
d40a26b to
cf68d58
Compare
Add a hidden setting to control whether the window is resizable. Fixes Return-To-The-Roots#1512
cf68d58 to
9cd0008
Compare
|
This (and the other) PR is old but I'd like to clean the PRs up. I had the conflicts resolved (in a local branch) but am wondering what the intention was. @Spikeone You seem to have been involved too?
I'm not sure if we really need option 2 as it looks like it can be done with 3 already. Or am I missing anything? |
|
@Flamefire maybe I'm weird but I do play RttR in windowed mode (1920x1080 on a 2560x1440 monitor) but not fullscreen.
So the case described is exactly what I'd love to have. Funny enough I was looking forward to this and was thinking about taking a look at it since it happened quite often to me recently as I went back into streaming RttR 😅 |
|
Ok so you basically want a non-resizable window, not a fullscreen window? Do you remember any other game that has similar options? Especially for changing the windowed size. I'd like to see how their options UI looks. |
|
Most other games simply don't support resizing the window, at least older games did not (when they even supported windowed mode at all). Sadly I can not remember any game that I played windowed that prevented resizing at all. So normally you don't have the choice - either its always enabled (so like we do it) or it doesn't work at all (as I'd like it in my case). Only other game I currently know about is my powershellgame where I added that option as well 😅 We do have an option to change the resolution, but it's always fullscreen resolution, even if windowed is enabled. |
That might be worth changing :) Just switch the label to "Window size" when "windowed" is selected. |
would be great - although we discussed this in #889 where, at least I had the feeling, you didn't like the idea. Would be happy to have all the features in any case :) |
Implement additional display modes in SDL2 and WinAPI backends:
Fixes #1512
Closes #1615
To-do:
Notes and references: