Add support for borderless Windows#1890
Add support for borderless Windows#1890Flamefire wants to merge 3 commits intoReturn-To-The-Roots:masterfrom
Conversation
Add a hidden setting to control whether the window is resizable. Fixes Return-To-The-Roots#1512
8447bcb to
7d2ad5c
Compare
Change the bitset to an enum with 3 modes for Fullscreen and window with and without border. Implement those modes in both VideoDrivers. Fixes Return-To-The-Roots#1512
7d2ad5c to
ededb8a
Compare
Check correct type and avoid clang-tidy trying to "simplify" the resulting boolean condition, i.e. > warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
84b9b09 to
d3241a6
Compare
|
Sounds good to me - just some question, I never thought about borderless window (Although this is probably what I'd like to have anyway) but wouldn't this be somewhat confusing for people since most would think its fullscreen windowed (as most modern game name it) but we don't have such option at all? |
|
My concern is rather: Without a title bar you cannot move it and it will always be centered. Not sure this suits everyone but you can't have that anyway.
The closest would be to set the size accordingly. That being said we can add a 4th option "Fullscreen windowed" (or maybe "windowed fullscreen" or "fullscreen window"?) to automatically set the size to the desktop size. IIRC SDL has even a flag for that, something called |
|
Oh, so the borderless window is the one that is not resizable? I honestly thought we'd just ignore the resize event and add an option to ignore that event |
|
Having no border makes it clear that the window cannot be resized as there is nothing to do that. I see it rather as an UI issue: Now we have 3 clear display modes. How/Where would be disable window resizing? Or shall we have a "fixed size window" option there? |
|
Well, what I was thinking about in general:
Those are the 3 modes I'd expect. Then I'd just love to have an additional option to:
Which would only apply to windowed mode. I still want to move the window around, but I don't want to resize it by accident. That was my initial intention when I asked @falbrechtskirchinger for this :) |
|
Hm, back to a bitset for the option then:
|
If I don't missunderstand this - yes. (Honestly, as long as I can play windowed, move the window and prevent it from resizing by accident, I'm happy) |
Continuation of #1602 to add a 3rd mode:
This removes the whole window frame making it non-resizeable:
Closes #1602 Fixes #1512
In the options screen I added a similar drop-down.
As an extension I would change "Fullscreen resolution" to "Window size" when selecting a windowed option in both settings. There all resolution options and the current window size will be added. Shall I? @Spikeone