Dev.ap/text overlay#583
Open
roedoejet wants to merge 3 commits into
Open
Conversation
Contributor
|
accomplished via a shared text overlay component
assists with indicating paragraph/page boundaries
16dae12 to
d785e2e
Compare
Member
|
Some thoughts based on a first pass of testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
The goal of this PR is to see how far we can get with a text overlay in solving some outstanding issues with the studio.
Namely:
Fixes?
Feedback sought?
Functionality mostly - I've only implemented the first 2 (and haven't done DNA spans yet). It's finnicky since we're relating word indices from tokenized XML back to plain text and the highlighting has to persist even when the tokenization changes (e.g. as a user is fixing the text). I think this would be easier with a rich text editor since we could update the structured text and then map it all to XML when we upload to the API, but it seems possible this way, without the bloat, but maybe with some extra cognitive overhead.
Priority?
medium
Tests added?
Lots of spec tests for various scenarios
How to test?
npx nx test:once studio-webConfidence?
medium. I got a lot of help from Claude Sonnet ( after planning it all out with @joanise) and some of the overlay css and alignment logic I'm just "trusting" with the help of spec tests and my own personal use of the site.
TODO
Version change?