Dev.ap/tip tap editor#585
Closed
roedoejet wants to merge 5 commits into
Closed
Conversation
This reverts commit fe88aef.
The ProseMirror document model and conversion to/from read-along XML and plain-text convention. No Angular component yet, this is the pure document/schema layer.
…error highlighting
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
This is a re-implemntation of #583 using TipTap rich text editor instead of text overlay.
The goal of this PR is to see how far we can get with a rich text editor in solving some outstanding issues with the studio.
Namely:
Fixes?
Feedback sought?
Functionality mostly - I've only implemented the first 2 (and haven't done DNA spans yet). It's more code, but that's mostly because instead of sending plain text, we're explicitly mapping to XML. A good 500 lines are just defining the TipTap Schema and methods for converting to/from that format and XML/plain text.
Priority?
medium
Tests added?
Lots of spec tests for various scenarios
How to test?
npx nx test:once studio-webConfidence?
medium. I got a lot of help from Claude Sonnet ( after planning it all out with @joanise)
TODO
Version change?