-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat!: Improve context announcement keyboard shortcuts #9863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
dac8a7d
fix: Improve context announcement keyboard shortcuts
gonfunko 9364af0
test: Add tests
gonfunko c56e493
fix: Don't use custom input labels
gonfunko 95e6ef0
fix: Use messages
gonfunko 74e44b0
chore: Run formatter
gonfunko ae1af19
refactor: Improve organization of information announcement shortcut
gonfunko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,4 @@ | ||
| { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. normally i manually undo this change but i vote we just keep it off and see what happens |
||
| "@metadata": { | ||
| "authors": [ | ||
| "Ajeje Brazorf", | ||
| "Amire80", | ||
| "Espertus", | ||
| "Liuxinyu970226", | ||
| "McDutchie", | ||
| "Metalhead64", | ||
| "Nike", | ||
| "Robby", | ||
| "Shirayuki", | ||
| "YaronSh" | ||
| ] | ||
| }, | ||
| "VARIABLES_DEFAULT_NAME": "default name - A simple, general default name for a variable, preferably short. For more context, see [[Translating:Blockly#infrequent_message_types]].\n{{Identical|Item}}", | ||
| "UNNAMED_KEY": "default name - A simple, default name for an unnamed function or variable. Preferably indicates that the item is unnamed.", | ||
| "TODAY": "button text - Button that sets a calendar to today's date.\n{{Identical|Today}}", | ||
|
|
@@ -452,6 +438,7 @@ | |
| "SHORTCUTS_FOCUS_WORKSPACE": "shortcut display text for the focus workspace shortcut, which moves focus to the workspace.", | ||
| "SHORTCUTS_FOCUS_TOOLBOX": "shortcut display text for the focus toolbox shortcut, which moves focus to the toolbox or flyout.", | ||
| "SHORTCUTS_INFORMATION": "shortcut display text for the information shortcut, which announces information about a focused element.", | ||
| "SHORTCUTS_EXTENDED_INFORMATION": "Description for the Shift-I keyboard shortcut that announces extended context about the currently focused element to screenreaders.", | ||
| "SHORTCUTS_DISCONNECT": "shortcut display text for the disconnect shortcut, which disconnects a block from its neighbor.", | ||
| "SHORTCUTS_NEXT_STACK": "shortcut display text for the next stack shortcut, which navigates to the next block stack.", | ||
| "SHORTCUTS_PREVIOUS_STACK": "shortcut display text for the previous stack shortcut, which navigates to the previous block stack.", | ||
|
|
@@ -525,5 +512,8 @@ | |
| "ICON_LABEL_WARNING_OPEN": "Label for an icon, used by screen readers to identify an open warning. Clicking on the icon closes the warning's bubble.", | ||
| "ARIA_LABEL_COMMENT": "ARIA label for a comment.", | ||
| "ARIA_LABEL_COMMENT_COLLAPSE": "ARIA label for an expanded comment's collapse button.", | ||
| "ARIA_LABEL_COMMENT_EXPAND": "ARIA label for a collapsed comment's expand button." | ||
| "ARIA_LABEL_COMMENT_EXPAND": "ARIA label for a collapsed comment's expand button.", | ||
| "CURRENT_BLOCK_ANNOUNCEMENT": "Screenreader announcement providing context about the currently focused block.", | ||
| "PARENT_BLOCKS_ANNOUNCEMENT": "Screenreader announcement providing context about the currently focused block's parents.", | ||
| "NO_PARENT_ANNOUNCEMENT": "Screenreader announcement informing users that the currently focused block has no parent blocks." | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.