Skip to content

feat!: Improve context announcement keyboard shortcuts#9863

Merged
gonfunko merged 6 commits into
v13from
info-shortcuts
May 13, 2026
Merged

feat!: Improve context announcement keyboard shortcuts#9863
gonfunko merged 6 commits into
v13from
info-shortcuts

Conversation

@gonfunko
Copy link
Copy Markdown
Contributor

The basics

The details

Resolves

Fixes RaspberryPiFoundation/blockly-keyboard-experimentation#764

Proposed Changes

This PR backports the Shift-I keyboard shortcut that announces the block hierarchy down to the current block, and backports the regular I keyboard shortcut behavior that announces a verbose description of the current block when one is focused.

@gonfunko gonfunko requested a review from a team as a code owner May 13, 2026 15:40
@gonfunko gonfunko requested a review from maribethb May 13, 2026 15:40
@github-actions github-actions Bot added the PR: fix Fixes a bug label May 13, 2026
Copy link
Copy Markdown
Contributor

@maribethb maribethb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a feat, not a fix, and it's a breaking change because you're registering a new keyboard shortcut

Comment thread packages/blockly/core/shortcut_items.ts Outdated
Comment thread packages/blockly/core/shortcut_items.ts Outdated
Comment thread packages/blockly/core/shortcut_items.ts
Comment thread packages/blockly/core/shortcut_items.ts
Comment thread packages/blockly/core/shortcut_items.ts Outdated
@gonfunko gonfunko changed the title fix: Improve context announcement keyboard shortcuts feat!: Improve context announcement keyboard shortcuts May 13, 2026
@github-actions github-actions Bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: feature Adds a feature and removed PR: fix Fixes a bug labels May 13, 2026
@gonfunko gonfunko requested a review from maribethb May 13, 2026 16:50
@@ -1,18 +1,4 @@
{
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normally i manually undo this change but i vote we just keep it off and see what happens

@gonfunko gonfunko merged commit 057356f into v13 May 13, 2026
5 checks passed
@gonfunko gonfunko deleted the info-shortcuts branch May 13, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Used to mark a PR or issue that changes our public APIs. PR: feature Adds a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants