Skip to content

[CP 1283] GPUOP-618 fix helm upgrade issue with latest Argo CRDs #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sajmera-pensando merged 2 commits into from
Apr 3, 2026
Merged

[CP 1283] GPUOP-618 fix helm upgrade issue with latest Argo CRDs #501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
328a582
GPUOP-618 fix helm upgrade issue with latest Argo CRDs (#1283)
biluriuday Apr 2, 2026
21e6ec5
Apply suggestion from @biluriuday
biluriuday Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundle/manifests/amd-gpu-operator.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ metadata:
capabilities: Seamless Upgrades
categories: AI/Machine Learning,Monitoring
containerImage: docker.io/rocm/amd-gpu-operator:dev
createdAt: "2026-03-30T18:09:02Z"
createdAt: "2026-04-02T12:26:30Z"
description: |-
Operator responsible for deploying AMD GPU kernel drivers, device plugin, device test runner and device metrics exporter
For more information, visit [documentation](https://instinct.docs.amd.com/projects/gpu-operator/en/latest/)
Expand Down
26 changes: 13 additions & 13 deletions hack/k8s-patch/template-patch/pre-upgrade-hook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,24 +226,24 @@ spec:
- /bin/sh
- -c
- |
kubectl apply -f /opt/helm-charts-crds-k8s/deviceconfig-crd.yaml
kubectl apply -f /opt/helm-charts-crds-k8s/remediationworkflowstatus-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/deviceconfig-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/remediationworkflowstatus-crd.yaml
{{- if index .Values "node-feature-discovery" "enabled" }}
kubectl apply -f /opt/helm-charts-crds-k8s/nfd-api-crds.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/nfd-api-crds.yaml
{{- end }}
{{- if .Values.kmm.enabled }}
kubectl apply -f /opt/helm-charts-crds-k8s/module-crd.yaml
kubectl apply -f /opt/helm-charts-crds-k8s/nodemodulesconfig-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/module-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/nodemodulesconfig-crd.yaml
{{- end }}
{{- if and .Values.remediation.enabled .Values.remediation.installCRDs }}
kubectl apply -f /opt/helm-charts-crds-k8s/clusterworkflowtemplate-crd.yaml
kubectl apply -f /opt/helm-charts-crds-k8s/cronworkflow-crd.yaml
kubectl apply -f /opt/helm-charts-crds-k8s/workflowartifactgctask-crd.yaml
kubectl apply -f /opt/helm-charts-crds-k8s/workflow-crd.yaml
kubectl apply -f /opt/helm-charts-crds-k8s/workfloweventbinding-crd.yaml
kubectl apply -f /opt/helm-charts-crds-k8s/workflowtaskresult-crd.yaml
kubectl apply -f /opt/helm-charts-crds-k8s/workflowtaskset-crd.yaml
kubectl apply -f /opt/helm-charts-crds-k8s/workflowtemplate-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/clusterworkflowtemplate-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/cronworkflow-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/workflowartifactgctask-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/workflow-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/workfloweventbinding-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/workflowtaskresult-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/workflowtaskset-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/workflowtemplate-crd.yaml
{{- end }}
restartPolicy: OnFailure
{{- end }}
Expand Down
2 changes: 1 addition & 1 deletion helm-charts-k8s/Chart.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ dependencies:
repository: file://./charts/remediation-crds
version: v1.0.0
digest: sha256:0806f6b6d7aa21be77bf1c91e720ae3238338a16f107df450a53b02ef940db1b
generated: "2026-03-27T12:42:32.543919608Z"
generated: "2026-04-02T12:26:25.920315689Z"
26 changes: 13 additions & 13 deletions helm-charts-k8s/templates/pre-upgrade-hook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,24 +226,24 @@ spec:
- /bin/sh
- -c
- |
kubectl apply -f /opt/helm-charts-crds-k8s/deviceconfig-crd.yaml
kubectl apply -f /opt/helm-charts-crds-k8s/remediationworkflowstatus-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/deviceconfig-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/remediationworkflowstatus-crd.yaml
{{- if index .Values "node-feature-discovery" "enabled" }}
kubectl apply -f /opt/helm-charts-crds-k8s/nfd-api-crds.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/nfd-api-crds.yaml
{{- end }}
{{- if .Values.kmm.enabled }}
kubectl apply -f /opt/helm-charts-crds-k8s/module-crd.yaml
kubectl apply -f /opt/helm-charts-crds-k8s/nodemodulesconfig-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/module-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/nodemodulesconfig-crd.yaml
{{- end }}
{{- if and .Values.remediation.enabled .Values.remediation.installCRDs }}
kubectl apply -f /opt/helm-charts-crds-k8s/clusterworkflowtemplate-crd.yaml
kubectl apply -f /opt/helm-charts-crds-k8s/cronworkflow-crd.yaml
kubectl apply -f /opt/helm-charts-crds-k8s/workflowartifactgctask-crd.yaml
kubectl apply -f /opt/helm-charts-crds-k8s/workflow-crd.yaml
kubectl apply -f /opt/helm-charts-crds-k8s/workfloweventbinding-crd.yaml
kubectl apply -f /opt/helm-charts-crds-k8s/workflowtaskresult-crd.yaml
kubectl apply -f /opt/helm-charts-crds-k8s/workflowtaskset-crd.yaml
kubectl apply -f /opt/helm-charts-crds-k8s/workflowtemplate-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/clusterworkflowtemplate-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/cronworkflow-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/workflowartifactgctask-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/workflow-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/workfloweventbinding-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/workflowtaskresult-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/workflowtaskset-crd.yaml
kubectl apply --server-side --force-conflicts -f /opt/helm-charts-crds-k8s/workflowtemplate-crd.yaml
{{- end }}
restartPolicy: OnFailure
{{- end }}
Expand Down
Loading