[CP 1283] GPUOP-618 fix helm upgrade issue with latest Argo CRDs#501
Merged
sajmera-pensando merged 2 commits intoROCm:mainfrom Apr 3, 2026
Conversation
(cherry picked from commit fe9ec91bcb097f1c82d51e6646e85d32e96096a9)
Contributor
Author
AI-Assisted Cherry-PickSource PR: #1283 The cherry-pick operation encountered merge conflicts which were resolved automatically using AI assistance. Files with conflicts (resolved by AI):
Original conflict in bundle/manifests/amd-gpu-operator.clusterserviceversion.yaml<<<<<<< HEAD
containerImage: docker.io/rocm/amd-gpu-operator:dev
createdAt: "2026-03-30T18:09:02Z"
=======
containerImage: registry.test.pensando.io:5000/amd-gpu-operator:dev
createdAt: "2026-04-02T12:26:30Z"
>>>>>>> fe9ec91b... GPUOP-618 fix helm upgrade issue with latest Argo CRDs (#1283)Original conflict in helm-charts-k8s/Chart.lock<<<<<<< HEAD
generated: "2026-03-27T12:42:32.543919608Z"
=======
generated: "2026-04-02T12:26:25.920315689Z"
>>>>>>> fe9ec91b... GPUOP-618 fix helm upgrade issue with latest Argo CRDs (#1283)Cherry-pick triggered by: ACP-Automation |
biluriuday
reviewed
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cp of pensando/gpu-operator#1283
Source PR Description (pensando/gpu-operator#1283):
The latest Argo Workflow CRDs exceed the 256 KB annotation size limit imposed by client-side kubectl apply. This causes CRD installation to fail during helm upgrade because client-side apply stores the entire resource manifest in the kubectl.kubernetes.io/last-applied-configuration annotation, which cannot accommodate the large Argo CRD schemas.
This PR switches the pre-upgrade hook to use server-side apply (--server-side --force-conflicts), eliminating the size constraint.
Cherrypick triggered by: ACP-Automation