RFC: remove private _Py symbols from pyo3-ffi#4379
Closed
davidhewitt wants to merge 1 commit intoPyO3:mainfrom
Closed
RFC: remove private _Py symbols from pyo3-ffi#4379davidhewitt wants to merge 1 commit intoPyO3:mainfrom
_Py symbols from pyo3-ffi#4379davidhewitt wants to merge 1 commit intoPyO3:mainfrom
Conversation
Contributor
|
I'm supportive of getting rid of I'm even more supportive of splitting these out 😂 To the extent there's stuff we need that doesn't have a public (or abi3) API, we should definitely make sure to turn them all into upstream bug reports. |
This was referenced Aug 6, 2024
d34ef60 to
11d3f0c
Compare
CodSpeed Performance ReportMerging #4379 will not alter performanceComparing Summary
|
This was referenced Aug 17, 2024
11d3f0c to
788a9f0
Compare
Member
Author
|
Superseded by #5592 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3762
This PR removes (as much as possible) all FFI functions and constants which start with
_Py. Given that the guidance in #3762 from the CPython team is that we shouldn't be using these symbols (except in some cases where they are ABI implementation details) I have proceeded to remove them rather than deprecate. In the cases where we need to use them for implementations I removed thepubfrom the symbol definition so thatpyo3-ffiretains use of the symbol without re-exporting.Marked as draft for now as I need to finish off later; if we agree that this is a good idea then I will:
Architecture.md/Contributing.mdto note that we don't expose these symbols.