pyo3-ffi: expose PyObject_Vectorcall(Method) on the stable abi on 3.12+#4853
pyo3-ffi: expose PyObject_Vectorcall(Method) on the stable abi on 3.12+#4853
PyObject_Vectorcall(Method) on the stable abi on 3.12+#4853Conversation
b7d6c64 to
2df776f
Compare
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks for extracting this out; I will try to rebase #4379 after this merges and assess how much is left / still needs to be split from there.
LGTM with one suggestion for a test...
76cafe3 to
a742dd7
Compare
|
Hmm, looks like something does not work for Python 3.9 and 3.10, due to "undefined reference to |
|
Ugh, I think it was only exposed as a symbol from 3.11: python/cpython#28893 Before then it was a (I guess this was my error from the original PR, sorry about that!) |
|
Thanks for the hint! I adjusted the cfgs, lets see if this works. |
|
Hooray! 🙌 |
This exposes
PyObject_Vectorcall(Method)on the stable abi on Python 3.12+ (extracted from #4379, with minor modification onPY_VECTORCALL_ARGUMENTS_OFFSETcfgs) and enables some of ourvectorcalloptimizations on the limited api.