Route SPM-unit state FIPS through persons in the release tool#426
Merged
Conversation
Build M's sparse run failed in the SNAP state take-up path: _spm_unit_state_fips called frame.broadcast(..., to="spm_unit"), but Frame.broadcast only targets the person entity. The path is a coverage- campaign restoration (the SNAP caseload targets) seeing full-scale execution for the first time — Build J predates it and no test exercised the helper. Broadcast household state to persons and collapse per SPM unit, failing closed if a unit ever spans two states or carries no person rows. Verified against the real base-r5 final-export frame: 352,078 SPM units across 51 states resolve cleanly. The regression test fails on the old helper and passes with the fix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build M's third sparse attempt failed in the SNAP state take-up path:
_spm_unit_state_fipscalledframe.broadcast("state_fips", to="spm_unit"), butFrame.broadcastonly targets the person entity — a plain API misuse in a coverage-campaign restoration (the #371/#376 SNAP caseload machinery) that no test exercised and Build J never ran.Fix: broadcast household state to persons and collapse per SPM unit, failing closed if a unit spans two states or carries no person rows.
Verification: regression test (aligned two-state fixture + split-unit guard) fails on the old helper, passes with the fix; full fiscal-refresh builder suite green; and the fixed helper runs clean against the real base-r5 final-export frame — 352,078 SPM units across 51 states. CI-ruff + format clean.
🤖 Generated with Claude Code