Fix SNAP state take-up crash: Frame.broadcast only targets person#414
Closed
daphnehanse11 wants to merge 1 commit into
Closed
Fix SNAP state take-up crash: Frame.broadcast only targets person#414daphnehanse11 wants to merge 1 commit into
daphnehanse11 wants to merge 1 commit into
Conversation
… SPM unit Frame.broadcast rejects group-entity targets, so the SNAP state take-up stage crashed on every release run. Broadcast state_fips to persons and take the first value per person_spm_unit_id, aligned to spm_unit table order. Build K local fix at b335241; same defect exists on main. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every release run crashes at the SNAP state take-up stage (#376's wiring):
_spm_unit_state_fipsaskedFrame.broadcastfor aspm_unittarget, but broadcast supports only the person entity by contract (bundle.py:757). The helper was never unit-covered, and no release-scale run had reached this stage until Build K (staging, 2026-07-13): earlier main-head attempts die at the QBI base-column requirement first (#412), so Build M will hit this crash once it clears its source stages.Fix
Broadcast
state_fipsto persons and collapse to one value per SPM unit viaperson_spm_unit_id(members of an SPM unit share a household, hence a state), aligned tospm_unittable order, with a hard error on member-less SPM units. Regression test added (borrows the_us_framefixture from the take-up stage tests).Verified at release scale: Build K (
b335241+ this fix, base-j0b50660a…) proceeds past the SNAP state take-up stage.Refs #372, #376.
🤖 Generated with Claude Code