Skip to content

remove base_frame and joints from VFC and JTAC parameters#479

Merged
marioprats merged 4 commits intomainfrom
12608-remove-VFC-JTAC-clean
Jan 29, 2026
Merged

remove base_frame and joints from VFC and JTAC parameters#479
marioprats merged 4 commits intomainfrom
12608-remove-VFC-JTAC-clean

Conversation

@suchkristenwow
Copy link

This is the sister PR to: PickNikRobotics/moveit_pro#16385

All VFC and JTAC related base_frame and joints parameters have been removed. The remaining base_frame references are in unrelated configs (fuse/navigation).

Parent Issue: PickNikRobotics/moveit_pro#12608

@suchkristenwow suchkristenwow added this to the 9.0 milestone Jan 23, 2026
@suchkristenwow suchkristenwow force-pushed the 12608-remove-VFC-JTAC-clean branch 3 times, most recently from e1d728b to fcd84d9 Compare January 26, 2026 16:38
@suchkristenwow suchkristenwow marked this pull request as ready for review January 26, 2026 17:33
left_velocity_force_controller:
ros__parameters:
# Joints that the controller will claim.
joints:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these would require a planning_group_name as a replacement
Unfortunately we don't have great CI in the example workspace. Only lab_sim is (kind of) covered.
The rest of configs need to be tested manually, at least to make sure they start.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this configuration:
moveit_pro on 12608-remove-VFC-JTAC

with moveit_pro_example_ws on 12608-remove-VFC-JTAC-clean

Objective Testing (I ran these objectives, which all worked):
- tested on hangar sim: find and spray plane, ML move boxes to loading zone, teleop
- tested on lab_sim: move flasks to burners, push button with a trajectory, teleop
- tested on kitchen_sim: writing demo
- tested on kinova_sim: move along path

Then I unload the controller, reload, configure and activate for each config we changed (since configuration is when the controller resolves planning group name):

  • kinova_sim: JTAC
  • lab_sim: JTAC
  • mock_sim: JTAC
  • kitchen_sim: VFC
  • dual_arm_sim: VFC (left + right)
    left_velocity_force_controller + right_velocity_force_controller

Ex:

if the controller is active
ros2 control set_controller_state joint_trajectory_admittance_controller inactive

ros2 control unload_controller joint_trajectory_admittance_controller

ros2 control load_controller joint_trajectory_admittance_controller

ros2 service call /controller_manager/configure_controller controller_manager_msgs/srv/ConfigureController "{name: 'joint_trajectory_admittance_controller'}"

ros2 control set_controller_state joint_trajectory_admittance_controller active
^Note: for the VFC tests, need to unload competing controllers first for this to work

Let me know if I can test something else on this PR :)

@suchkristenwow suchkristenwow force-pushed the 12608-remove-VFC-JTAC-clean branch from fcd84d9 to 95bbb33 Compare January 28, 2026 23:36
@suchkristenwow suchkristenwow force-pushed the 12608-remove-VFC-JTAC-clean branch from 95bbb33 to 352bc5f Compare January 28, 2026 23:58
@marioprats
Copy link

I rebased and updated a couple of extra JTAC instances that we added yesterday. Tested and ready to go!

Copy link

@marioprats marioprats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@marioprats marioprats enabled auto-merge January 29, 2026 08:03
@marioprats marioprats merged commit 5eadc1b into main Jan 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants