Skip to content

Fix Minion Pact damage applying without nearby minions #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
unrealdreamz wants to merge 1 commit into
base: dev
Choose a base branch
from
+29 −4
Open

Fix Minion Pact damage applying without nearby minions #1906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions spec/System/TestSkills_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,4 +245,29 @@ describe("TestSkills", function()

assert.True(build.calcsTab.calcsOutput.Cooldown == 10)
end)

it("Test Minion Pact damage requires a minion in your presence", function()
build.itemsTab:CreateDisplayItemFromRaw([[
New Item
Warmonger Bow
Quality: 0
]])
build.itemsTab:AddDisplayItem()
runCallback("OnFrame")

build.skillsTab:PasteSocketGroup("Lightning Arrow 1/0 1\nMinion Pact I 1/0 1")
runCallback("OnFrame")

local activeSkill = build.calcsTab.calcsEnv.player.activeSkillList[1]
assert.are.equals(0, activeSkill.skillModList:Sum("MORE", activeSkill.skillCfg, "Damage"))
local noMinionDps = build.calcsTab.calcsOutput.TotalDPS

build.configTab.input.multiplierMinionsInPresence = 1
build.configTab:BuildModList()
runCallback("OnFrame")

activeSkill = build.calcsTab.calcsEnv.player.activeSkillList[1]
assert.are.equals(30, activeSkill.skillModList:Sum("MORE", activeSkill.skillCfg, "Damage"))
assert.True(build.calcsTab.calcsOutput.TotalDPS > noMinionDps)
end)
end)
4 changes: 2 additions & 2 deletions src/Data/Skills/sup_int.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6103,7 +6103,7 @@ skills["SupportMinionPactPlayer"] = {
statDescriptionScope = "gem_stat_descriptions",
statMap = {
["support_minion_pact_damage_+%_final"] = {
mod("Damage", "MORE", nil),
mod("Damage", "MORE", nil, { type = "MultiplierThreshold", var = "MinionPresenceCount", threshold = 1 }),
},
},
baseFlags = {
Expand Down Expand Up @@ -6140,7 +6140,7 @@ skills["SupportMinionPactPlayerTwo"] = {
statDescriptionScope = "gem_stat_descriptions",
statMap = {
["support_minion_pact_damage_+%_final"] = {
mod("Damage", "MORE", nil),
mod("Damage", "MORE", nil, { type = "MultiplierThreshold", var = "MinionPresenceCount", threshold = 1 }),
},
},
baseFlags = {
Expand Down
4 changes: 2 additions & 2 deletions src/Export/Skills/sup_int.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1137,7 +1137,7 @@ statMap = {
#set SupportMinionPactPlayer
statMap = {
["support_minion_pact_damage_+%_final"] = {
mod("Damage", "MORE", nil),
mod("Damage", "MORE", nil, { type = "MultiplierThreshold", var = "MinionPresenceCount", threshold = 1 }),
},
},
#mods
Expand All @@ -1147,7 +1147,7 @@ statMap = {
#set SupportMinionPactPlayerTwo
statMap = {
["support_minion_pact_damage_+%_final"] = {
mod("Damage", "MORE", nil),
mod("Damage", "MORE", nil, { type = "MultiplierThreshold", var = "MinionPresenceCount", threshold = 1 }),
},
},
#mods
Expand Down