Fix Minion Pact damage applying without nearby minions#1906
Open
unrealdreamz wants to merge 1 commit into
Open
Fix Minion Pact damage applying without nearby minions#1906unrealdreamz wants to merge 1 commit into
unrealdreamz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Minion Pact's data description says it only takes effect when there is a minion with enough life to drain, but the stat map emitted an unconditional
Damage MOREmodifier. As a result, any supported player skill received Minion Pact damage even when the build had no minion state at all.Fix
The support stat now carries a
MultiplierThresholdonMinionPresenceCount >= 1. This reuses the existing configuration path for nearby minions instead of adding a new UI surface or inventing broader minion simulation.Validation
gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state open -S '1724' --json number,title,headRefName,author,url --jq '.'→[]gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state open -S '"Minion Pact"' --json number,title,headRefName,author,url --jq '.'→[]git diff --check→ pass (CRLF warning only)git diff --cached --check→ pass (CRLF warning only)git show --check --stat --oneline HEAD→ passI did not run the containerized Busted suite locally; this machine is currently being kept free of extra containers/windows. The included spec is targeted at the changed support stat path.
Risk / Rollback
Risk is localized to Minion Pact I/II. Builds using Minion Pact now need an explicit minion-in-presence count for its conditional damage to apply. Rollback is a revert of this commit.
Fixes #1724