Skip to content

Add command line parsing and rabbitmq classic queue support#338

Merged
danielmarbach merged 8 commits intomasterfrom
feature/command-line-params
Mar 11, 2026
Merged

Add command line parsing and rabbitmq classic queue support#338
danielmarbach merged 8 commits intomasterfrom
feature/command-line-params

Conversation

@danielmarbach
Copy link
Contributor

@danielmarbach danielmarbach commented Mar 9, 2026

Fixes #329 and #328

This pull request introduces significant improvements to the transport configuration and cleanup process in MassTransit acceptance tests, particularly for RabbitMQ, Azure Service Bus, and Amazon SQS. The main enhancement is switching transport configuration methods to return cleanup delegates, enabling automated queue cleanup after tests. Additionally, a new test project for RabbitMQ Classic queues is added, and minor corrections and configuration updates are included.

Transport configuration and cleanup refactoring:

  • Changed IConfigureTransportTestExecution interface and implementations so that transport setup methods (ConfigureTransportForMassTransitEndpoint and ConfigureTransportForConnector) now return delegates for cleanup, allowing tests to automatically delete or purge queues after execution. [1] [2] [3] [4] [5] [6] [7] [8]
  • Updated ConnectorComponent and MassTransitComponent classes to invoke these cleanup delegates during test shutdown, ensuring proper resource management and isolation between test runs. [1] [2] [3] [4]

RabbitMQ Classic test project addition:

  • Added a new project ServiceControl.Connector.MassTransit.AcceptanceTests.RabbitMQ.Classic targeting RabbitMQ Classic queues, including project file, editor config, and suite configuration. [1] [2] [3]

RabbitMQ queue management enhancements:

  • Introduced queue deletion and purging logic in ConfigureRabbitMQTransportTestExecution, along with a specialized TestRabbitMQTransport class to track queues created during tests.
  • Added ConnectionHelper to centralize RabbitMQ connection factory creation for queue operations.

Other improvements and corrections:

  • Fixed environment variable name typo in RabbitMQTestAttribute.
  • Minor code cleanup and refactoring in MassTransit component extensions.
  • Updated using directives for clarity and correctness. [1] [2]

@danielmarbach danielmarbach changed the title Add command line parsing and quorum queue support Add command line parsing and rabbitmq queue support Mar 9, 2026
@SeanFeldman SeanFeldman changed the title Add command line parsing and rabbitmq queue support Add command line parsing and rabbitmq classic queue support Mar 9, 2026
Copy link
Collaborator

@SeanFeldman SeanFeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@danielmarbach danielmarbach marked this pull request as ready for review March 10, 2026 09:45
@danielmarbach danielmarbach merged commit 17cc25e into master Mar 11, 2026
7 checks passed
@danielmarbach danielmarbach deleted the feature/command-line-params branch March 11, 2026 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No way to pass parameters via command line in console mode

5 participants