Add command line parsing and rabbitmq classic queue support#338
Merged
danielmarbach merged 8 commits intomasterfrom Mar 11, 2026
Merged
Add command line parsing and rabbitmq classic queue support#338danielmarbach merged 8 commits intomasterfrom
danielmarbach merged 8 commits intomasterfrom
Conversation
SeanFeldman
approved these changes
Mar 9, 2026
src/ServiceControl.Connector.MassTransit.Host/ConnectorOptionsValidator.cs
Outdated
Show resolved
Hide resolved
…gation in acceptance tests
Co-authored-by: Sean Feldman <SeanFeldman@users.noreply.github.com>
jpalac
approved these changes
Mar 11, 2026
PhilBastian
approved these changes
Mar 11, 2026
stevedowling
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #329 and #328
This pull request introduces significant improvements to the transport configuration and cleanup process in MassTransit acceptance tests, particularly for RabbitMQ, Azure Service Bus, and Amazon SQS. The main enhancement is switching transport configuration methods to return cleanup delegates, enabling automated queue cleanup after tests. Additionally, a new test project for RabbitMQ Classic queues is added, and minor corrections and configuration updates are included.
Transport configuration and cleanup refactoring:
IConfigureTransportTestExecutioninterface and implementations so that transport setup methods (ConfigureTransportForMassTransitEndpointandConfigureTransportForConnector) now return delegates for cleanup, allowing tests to automatically delete or purge queues after execution. [1] [2] [3] [4] [5] [6] [7] [8]ConnectorComponentandMassTransitComponentclasses to invoke these cleanup delegates during test shutdown, ensuring proper resource management and isolation between test runs. [1] [2] [3] [4]RabbitMQ Classic test project addition:
ServiceControl.Connector.MassTransit.AcceptanceTests.RabbitMQ.Classictargeting RabbitMQ Classic queues, including project file, editor config, and suite configuration. [1] [2] [3]RabbitMQ queue management enhancements:
ConfigureRabbitMQTransportTestExecution, along with a specializedTestRabbitMQTransportclass to track queues created during tests.ConnectionHelperto centralize RabbitMQ connection factory creation for queue operations.Other improvements and corrections:
RabbitMQTestAttribute.