Fix legacy conversion #13529
Open
Fix legacy conversion #13529
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Legacy conversion was broken in f00727c due to dependency loop: legacy conversion was dependent on the max durability, but getting the max durability now also became dependent on legacy conversion.
MartijnMuijsers
force-pushed
the
fix/legacy-conversion
branch
from
e76788d to
5c03848
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy conversion was broken in f00727c57e564f3a8cb875183a54142feb693db7 due to dependency loop: legacy conversion was dependent on the max durability, but getting the max durability now also became dependent on legacy conversion.
This PR fixes it. For example,
LEGACY_RECORD_3.isRecord()will again return true (like it did before the conversion broke) instead of false.