Remove hard-coded max stack sizes from Material

[MartijnMuijsers]

This removes hard-coded max stack sizes from Material, and defers to ItemType instead.

I've kept the old behavior of returning 64 for all blocks (since maxStack was initialized to that value for all blocks) and 0 for LEGACY_AIR, to prevent old plugins that expect those values from breaking. This could be replaced by

Preconditions.checkArgument(type != null, "The Material is not an item!");

but that could break legacy plugins, which is the whole reason for maintaining Material I suppose.

EDIT: This would break max stack sizes for legacy materials because legacy conversion is currently broken, but that is fixed by #13529

[Lulu13022002]

Might as well fix the legacy material conversion (didn't really cared about it at the time) for example take the following in the TestPlugin (onEnable):

Material.LEGACY_RECORD_3.getMaxStackSize() <-- return 1 OK
Material.LEGACY_RECORD_4.getMaxStackSize() <-- return 64 WRONG

In all case you would need to update the generator for the non legacy material.

[MartijnMuijsers]

@Lulu13022002 Done! #13529

[Lulu13022002]

Thanks, can you update the generator too for this PR?

[MartijnMuijsers]

Of course! I've updated the generator, but I'm unfamiliar with if there is currently any test to verify it~ (apart from a review)

[Lulu13022002]

The way to test it is generally to run it, normally you would have used the generator in the first place ^^

[MartijnMuijsers]

I don't know how to run it haha. I've tried running all the tasks under generation but they have no effect, I'm not sure where the output ends up. I can't find any documentation about it.

[Lulu13022002]

Ah sorry the only documentation for this is on my original commit (which has probably been squashed during the update). Make sure to uncomment the line in paper-generator.settings.gradle.kts to include the project then you want the rewriteApi task (because Material is part of the api and you want to generate content between the comment markers).
The changes are applied directly so if you see no difference then it probably works but you can just delete all the constants to make sure it works (not the legacy tho). From my test it works fine!

[Lulu13022002]

One thing to note is that this one will now have a max stack size of 64 instead of 16 idk how much you care about it? since it doesn't make sense for blocks to have a max stack size anyway.

[MartijnMuijsers]

I personally don't care about it, and I agree it makes no sense at all. I could totally see existing plugins checking for max stack size being 0 for LEGACY_AIR, but any existing plugin actually somehow producing any practical difference based on the return value of max stack size for wall signs seems very unlikely!

[MartijnMuijsers]

I did get :paper-generator:rewriteApi running successfully by the way, but it didn't add or modify any files for me. Is it supposed to overwrite Material.java?

[Lulu13022002]

The changes are applied directly so if you see no difference then it probably works but you can just delete all the constants to make sure it works (not the legacy tho). From my test it works fine!

Yes it's fine you already did what the generator was already supposed to generate but manually.