[Backport 8.x] Fix regex node lookup regression from PUP-11515#515
Merged
Conversation
8 tasks
bastelfreak
approved these changes
Jul 6, 2026
Open
corporate-gadfly
force-pushed
the
backport-481-to-8.x
branch
2 times, most recently
from
57ce87e to
a5a5192
Compare
corporate-gadfly
force-pushed
the
backport-481-to-8.x
branch
from
a5a5192 to
6857e88
Compare
- The LOOKAROUND_OPERATORS tokens introduced in 5d09d7f are uppercase, but TypeCollection#munge_name() lowercases all lookup keys, so regex nodes with group syntax (e.g. (?:-test)) were stored under a key that could never be found again, producing "Cannot find definition Node". Fix: use downcased lookaround operators. Fixes: #14 Signed-off-by: Corporate Gadfly <haroon.rafique@gmail.com> Co-authored-by: GitHub Copilot <noreply@github.com> (cherry picked from commit 403896f)
corporate-gadfly
force-pushed
the
backport-481-to-8.x
branch
from
6857e88 to
31f8a53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #481 to
8.x.