Fix regex node lookup regression from PUP-11515

[corporate-gadfly]

Short description

The LOOKAROUND_OPERATORS tokens introduced in 5d09d7f are uppercase, but TypeCollection#munge_name() lowercases all lookup keys, so regex nodes with group syntax (e.g. (?:-test)) were stored under a key that could never be found again, producing "Cannot find definition Node".

Fix: use downcased lookaround operators.

Fixes: #14

Checklist

I have:

• read the CONTRIBUTING.md document
• read and accepted the Developer Certificate of Origin document and added a Signed-off-by annotation to each of my commits
• read and accepted the AI Policy document and added Generated-by or Assisted-by annotations to each of my commits created with the help of an AI agent
• tested this code
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)

[binford2k]

This is a relatively harmless failure. It just means that on Windows / Ruby 3.2 that the generate face will do more work than it has to do. It should only be generating types for changed files, but with this change it's generating for all. It's still generating properly.

I don't have time to keep digging just now, but you might poke at

openvox/lib/puppet/generate/type.rb

Lines 47 to 53 in acd591a

	# Determines if the output file is up-to-date with respect to the input file.
	# @param [String, nil] The path to output to, or nil if determined by input
	# @return [Boolean] Returns true if the output is up-to-date or false if not.
	def up_to_date?(outputdir)
	f = effective_output_path(outputdir)
	Puppet::FileSystem.exist?(f) && (Puppet::FileSystem.stat(@path) <=> Puppet::FileSystem.stat(f)) <= 0
	end

Either something about this patch changes how the path is calculated or something about this patch changes how mtime works.

The only link I found between node name and the generate types command is that it uses Puppet::Node::Environment to identify where to look at files. If you have a Windows node handy, you might see if there's any difference in Puppet.lookup(:current_environment) in the context of that test.

[corporate-gadfly]

Thankfully, my life is devoid of Windows at the moment 🤷.

[OpenVoxProjectBot]

Successfully created backport PR for 8.x:

• [Backport 8.x] Fix regex node lookup regression from PUP-11515 #515

[corporate-gadfly]

FYI, flaky test failure was fixed by PR #522.