Open
Conversation
|
Closed
Member
|
Thanks @rjwignar - sorry for overlooking this PR for so long. Your change looks good to me. Are you able/willing to sign the CLA and update the DCO so those checks pass? |
Collaborator
|
@rjwignar it would be lovely to get your change merged. If you find some time, please look into the CLA / DCO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #19
Following @jminor's suggestion in #27 (comment), I've been able to use an
ImGui::Checkbox()while keepingItem::_enabledprivate.Clips will be greyed out when disabled. Re-enabling clips will return them to their original color.
Tracks can be enabled/disabled, but this PR does not include UI changes to distinguish enabled from disabled Tracks.
Summary of changes
timeline.cpp:DrawItem(), added conditional greying out on disabled clipsfill_colorUIColorFromName("")to getIM_COL32(0x88, 0x88, 0x88, 0xff)inspector.cpp:ImGui::Checkbox():Below is a quick demo of enabling/disabling clips

Strech Goal (Greying of entire tracks):
I'm holding off on this stretch goal as I'm not entirely clear on the desired behaviour, such as whether to grey out the just Track header or the Track header plus every clip the Track contains. I'd be willing to work on this in a follow-up Issue, if it's alright with the team.
Thank you for your patience with this feature and for considering these changes.