[codex] fix extract-knowhow report template generation#23
Open
ktwu01 wants to merge 2 commits intoOpenScientists:mainfrom
Open
[codex] fix extract-knowhow report template generation#23ktwu01 wants to merge 2 commits intoOpenScientists:mainfrom
ktwu01 wants to merge 2 commits intoOpenScientists:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
const DATA = __REPORT_DATA__;assignmentDATA.institutionWhy
Generated reports could become invalid HTML/JS when placeholder replacement also touched the explanatory comment in the template, leaving duplicated JSON and stray text in the script block. The template also incorrectly filled the institution field from
DATA.email.Impact
This makes generated
~/.openscientist/report.htmlfiles more reliable, preserves the interactive review UI, and fixes the author institution field in the browser form.Validation
npm test