🏗️🔧:point semgrep at the branch we have - #1831
Merged
Merged
Conversation
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
DerekNonGeneric
force-pushed
the
fix/semgrep-default-branch
branch
from
August 18, 2026 16:22
f939436 to
c86a7e2
Compare
OpenINFbot
approved these changes
Aug 18, 2026
|
The commit queue did not land this. See https://github.com/OpenINF/openinf.github.io/actions/runs/32160179962 — the label has been taken back off, so re-applying it is a deliberate second try. |
|
The commit queue did not land this. See https://github.com/OpenINF/openinf.github.io/actions/runs/32160425459 — the label has been taken back off, so re-applying it is a deliberate second try. |
DerekNonGeneric
force-pushed
the
fix/semgrep-default-branch
branch
from
August 18, 2026 18:25
c86a7e2 to
2e9054a
Compare
The template it came from rescans when the workflow file changes, on main or master. This repository has neither, so that trigger has never fired. Pull request and weekly scans were unaffected and have been running throughout. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
DerekNonGeneric
force-pushed
the
fix/semgrep-default-branch
branch
from
August 18, 2026 20:16
2e9054a to
29960b3
Compare
|
The commit queue did not land this. See https://github.com/OpenINF/openinf.github.io/actions/runs/32181528999 — the label has been taken back off, so re-applying it is a deliberate second try. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
semgrep.ymlcame from the vendor's template, which rescans when the workflowfile itself changes, on
mainormaster. This repository has neither, sothat trigger has never fired. It now names
live.Scope
This is narrower than it might look, and worth stating plainly so nobody reads
it as a security gap that was open:
meant "rescan after editing the workflow"
Nothing was unscanned. The trigger was dead config, of the same kind as the
Lint and test badge in #1830: a branch name that does not exist here.
Verification
Merging this should fire the trigger it fixes, since the push lands on
liveand touches
.github/workflows/semgrep.yml. If apushrun appears forSemgrep afterwards, it works.
Not done here
The
pathsfilter meansliveis still only scanned weekly and per pullrequest, never on what actually lands. That is a defensible place to stop, but
if you want the squashed result scanned the way #1830 now lints it, dropping
the
pathsfilter is the change. Left alone deliberately.