Skip to content

🏗️🔧:point semgrep at the branch we have - #1831

Merged
openinf-commit-queue[bot] merged 1 commit into
livefrom
fix/semgrep-default-branch
Aug 18, 2026
Merged

🏗️🔧:point semgrep at the branch we have#1831
openinf-commit-queue[bot] merged 1 commit into
livefrom
fix/semgrep-default-branch

Conversation

@DerekNonGeneric

Copy link
Copy Markdown
Member

semgrep.yml came from the vendor's template, which rescans when the workflow
file itself changes, on main or master. This repository has neither, so
that trigger has never fired. It now names live.

Scope

This is narrower than it might look, and worth stating plainly so nobody reads
it as a security gap that was open:

  • pull requests — running throughout, 39 runs
  • weekly schedule — running, last fired 16 Aug, passing
  • push — never fired, and paths-limited to this one file, so it only ever
    meant "rescan after editing the workflow"

Nothing was unscanned. The trigger was dead config, of the same kind as the
Lint and test badge in #1830: a branch name that does not exist here.

Verification

Merging this should fire the trigger it fixes, since the push lands on live
and touches .github/workflows/semgrep.yml. If a push run appears for
Semgrep afterwards, it works.

Not done here

The paths filter means live is still only scanned weekly and per pull
request, never on what actually lands. That is a defensible place to stop, but
if you want the squashed result scanned the way #1830 now lints it, dropping
the paths filter is the change. Left alone deliberately.

@netlify

netlify Bot commented Aug 18, 2026

Copy link
Copy Markdown

Deploy Preview for gh-pages-openinf ready!

Name Link
🔨 Latest commit 29960b3
🔍 Latest deploy log https://app.netlify.com/projects/gh-pages-openinf/deploys/6a84bdae8b7c9600082cba06
😎 Deploy Preview https://deploy-preview-1831--gh-pages-openinf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@DerekNonGeneric
DerekNonGeneric force-pushed the fix/semgrep-default-branch branch from f939436 to c86a7e2 Compare August 18, 2026 16:22
@OpenINFbot OpenINFbot added the commit-queue Land this pull request when its checks pass label Aug 18, 2026
@openinf-commit-queue openinf-commit-queue Bot removed the commit-queue Land this pull request when its checks pass label Aug 18, 2026
@openinf-commit-queue

Copy link
Copy Markdown

The commit queue did not land this. See https://github.com/OpenINF/openinf.github.io/actions/runs/32160179962 — the label has been taken back off, so re-applying it is a deliberate second try.

@OpenINFbot OpenINFbot added the commit-queue Land this pull request when its checks pass label Aug 18, 2026
@openinf-commit-queue openinf-commit-queue Bot removed the commit-queue Land this pull request when its checks pass label Aug 18, 2026
@openinf-commit-queue

Copy link
Copy Markdown

The commit queue did not land this. See https://github.com/OpenINF/openinf.github.io/actions/runs/32160425459 — the label has been taken back off, so re-applying it is a deliberate second try.

The template it came from rescans when the workflow file changes, on
main or master. This repository has neither, so that trigger has never
fired.

Pull request and weekly scans were unaffected and have been running
throughout.

Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
Assisted-by: Claude-Code:claude-opus-5
@DerekNonGeneric
DerekNonGeneric force-pushed the fix/semgrep-default-branch branch from 2e9054a to 29960b3 Compare August 18, 2026 20:16
@DerekNonGeneric DerekNonGeneric added the commit-queue Land this pull request when its checks pass label Aug 18, 2026
@openinf-commit-queue openinf-commit-queue Bot removed the commit-queue Land this pull request when its checks pass label Aug 18, 2026
@openinf-commit-queue

Copy link
Copy Markdown

The commit queue did not land this. See https://github.com/OpenINF/openinf.github.io/actions/runs/32181528999 — the label has been taken back off, so re-applying it is a deliberate second try.

@DerekNonGeneric DerekNonGeneric added the commit-queue Land this pull request when its checks pass label Aug 18, 2026
@openinf-commit-queue
openinf-commit-queue Bot merged commit 50bbe0d into live Aug 18, 2026
15 of 16 checks passed
@openinf-commit-queue openinf-commit-queue Bot removed the commit-queue Land this pull request when its checks pass label Aug 18, 2026
@DerekNonGeneric
DerekNonGeneric deleted the fix/semgrep-default-branch branch August 18, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants