🏗️🔧：stop the queue citing its own refusal - #1832
Merged
openinf-commit-queue[bot] merged 1 commit intoAug 18, 2026
Merged
Conversation
A refusal exits non-zero, so an attempt made while a check was still running leaves a failed check named Land on the commit. The next attempt read that as a check that did not pass, and refused. Every attempt after the first cited the first, so a pull request labelled a moment too early could never be landed from that commit again. The queue already left its own run out, but by run id, which only matches the run doing the asking. The workflow now also passes the name it reports as, and any run under that name is left out whether it is this one or one from before. Two tests: the refusal it left behind is ignored, and a failure that is not the queue's is still reported. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
DerekNonGeneric
added
the
commit-queue
openinf-commit-queue
Bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Labelling #1831 a moment before its checks finished made it unlandable from
that commit, permanently. The second attempt, with everything green, said:
Landis the queue's own job.What happens
A refusal exits non-zero, so the first attempt left a completed check named
Landwith conclusionfailureon the head commit.checksVerdictleft thequeue's own run out by run id, which matches only the run doing the asking, so
on the second attempt that earlier check survived the filter, counted as a
check that did not pass, and refused. Which left another failed
Landbehind,and so on.
The first refusal decides every later one. Any pull request labelled while a
check is in flight is stuck until it is pushed to, and the reason it gives is
its own complaint from a minute earlier.
The fix
The workflow passes the name it reports as, and any run under that name is left
out whether it is this one or one from before. The invariant is that the queue
is never a reason to refuse itself: the current run cannot finish until it
stops waiting, and an earlier run describes an attempt rather than the code.
The run id check stays. It costs a line and still holds if the name and the
job's
name:ever drift apart.Tests
checksVerdicthad two cases for its own run: the one asking is skipped, and adifferent workflow's run still counts. Neither covered a previous run of the
queue itself, which is the gap. Two added:
Both fail without the change.
Checks
nps build && nps testpasses, 76 unit tests.After this lands
#1831 is still stuck on its current commit, since the stale check sits on that
SHA and this only changes what future runs read. Landing it needs either a
push to the branch or a merge through the interface.