🏗️🔧：lint live, and let the badge say so - #1830
Merged
Merged
Conversation
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The badge reported whichever branch ran last. A pull-request-only workflow leaves the default branch with no status, so a contributor's failing pull request turned the front page red while live was fine. Nothing checked live either. The queue squashes without rebuilding, so two changes that passed separately could land together and break something, with only the deploy having run. The path filters stay for pull requests. On live the whole suite runs. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
DerekNonGeneric
force-pushed
the
fix/lint-live-and-badge
branch
from
August 18, 2026 06:09
bad03d7 to
3e01e73
Compare
OpenINFbot
approved these changes
Aug 18, 2026
openinf-commit-queue
Bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Lint and test badge on the README was reporting a branch nobody asked
about.
lint-and-test.ymlran onpull_requestonly, so it has never run onlive.A workflow badge shows the default branch by default, and with no run there it
falls back to whichever branch ran most recently. That means a contributor's
failing pull request turns the badge on the front page red while
liveisperfectly healthy, which is what happened.
The larger half
Nothing checked
liveat all. Onlycodeql-analysisanddeployrun on push.The commit queue squashes a pull request into
livewithout rebuilding it, sotwo changes that each passed on their own branch could land together, conflict
semantically, and nothing but the deploy would run.
Adding the push trigger fixes both: the badge starts reporting
live, andlivegets verified after every landing.What changed
on: pull_requestbecomespull_requestpluspushonlivenps test, now also runs on pushThe path filters stay as they are for pull requests, where checking only what
changed keeps feedback fast. On
livethe filters are beside the point, so thewhole suite runs whatever the change touched.
Why this will not go red spuriously
verify.commitsresolves its base fromGITHUB_BASE_REF, falling back toorigin/live. On a push tolivethere is no base ref, so it resolvesorigin/live, which isHEAD. The range is empty, it checks nothing, and itexits clean.
Unrelated, noticed while looking
semgrep.ymlhaspush: branches: [main, master]. Neither branch exists inthis repository;
liveis the only one. That trigger has never fired.