Skip to content

Proposal: add Acceptable label for pragmatic PR review choices#88

Merged
juanmichelini merged 2 commits intomainfrom
openhands-workspace-4LjJbt6TjfVisP9g6gbYV8
Mar 5, 2026
Merged

Proposal: add Acceptable label for pragmatic PR review choices#88
juanmichelini merged 2 commits intomainfrom
openhands-workspace-4LjJbt6TjfVisP9g6gbYV8

Conversation

@malhotra5
Copy link
Contributor

Summary

Updates the github-pr-review skill to handle cases where the agent acknowledges that improvements can be made but are out of scope for the current PR, or when changes are pragmatic considering constraints.

Changes

  • Added 🟢 Acceptable priority label - For acknowledging pragmatic trade-offs that are reasonable given constraints or out of scope for the PR
  • Added "Pragmatic Choices" subsection - Explains when to use the Acceptable label:
    • When improvements are out of scope for the current PR
    • When the choice is pragmatic given project constraints (time, complexity, backwards compatibility)
    • When the trade-off is reasonable and doesn't introduce bugs or security issues
  • Added example showing how to use the Acceptable label
  • Updated Summary section to emphasize not blocking PRs for pragmatic choices

Example Usage

🟢 Acceptable: This helper could be extracted to a shared utility, but keeping it inline is reasonable for this PR's scope.

Rationale

This prevents the reviewer from marking items as "needs rework" when the code is a reasonable pragmatic choice, even if theoretically it could be improved in a future PR.

- Add 🟢 Acceptable priority label for acknowledging pragmatic trade-offs
- Add guidance for marking out-of-scope improvements as acceptable
- Include example showing how to use the Acceptable label
- Update summary to emphasize not blocking PRs for pragmatic choices

Co-authored-by: openhands <openhands@all-hands.dev>
@malhotra5 malhotra5 changed the title Add Acceptable label for pragmatic PR review choices Proposal: add Acceptable label for pragmatic PR review choices Mar 3, 2026
@malhotra5 malhotra5 marked this pull request as ready for review March 3, 2026 17:13
Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit unclear to me if this will work as I'm guessing we'd like it to work, but maybe. Let's try it.

(I'm guessing you'd like to nudge the LLM to not prevent itself from approving when it has some stuff to say that is arguably out of scope. An alternative there is to reply directly to that inline thread and tell it your decision and maybe even tell it to accept it - ha. It doesn't see top-level comments, but next review it will see the replies 😅)

@juanmichelini
Copy link
Collaborator

@enyst @malhotra5 I love this and need it, so I'm merging it.

@juanmichelini juanmichelini merged commit 444a4c3 into main Mar 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants