Proposal: add Acceptable label for pragmatic PR review choices#88
Merged
juanmichelini merged 2 commits intomainfrom Mar 5, 2026
Merged
Conversation
- Add 🟢 Acceptable priority label for acknowledging pragmatic trade-offs - Add guidance for marking out-of-scope improvements as acceptable - Include example showing how to use the Acceptable label - Update summary to emphasize not blocking PRs for pragmatic choices Co-authored-by: openhands <openhands@all-hands.dev>
malhotra5
commented
Mar 3, 2026
enyst
approved these changes
Mar 3, 2026
Collaborator
enyst
left a comment
There was a problem hiding this comment.
It's a bit unclear to me if this will work as I'm guessing we'd like it to work, but maybe. Let's try it.
(I'm guessing you'd like to nudge the LLM to not prevent itself from approving when it has some stuff to say that is arguably out of scope. An alternative there is to reply directly to that inline thread and tell it your decision and maybe even tell it to accept it - ha. It doesn't see top-level comments, but next review it will see the replies 😅)
Collaborator
|
@enyst @malhotra5 I love this and need it, so I'm merging it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
github-pr-reviewskill to handle cases where the agent acknowledges that improvements can be made but are out of scope for the current PR, or when changes are pragmatic considering constraints.Changes
Example Usage
Rationale
This prevents the reviewer from marking items as "needs rework" when the code is a reasonable pragmatic choice, even if theoretically it could be improved in a future PR.