Skip to content

Commit 444a4c3

Browse files
Proposal: add Acceptable label for pragmatic PR review choices (#88)
* Add Acceptable label for pragmatic PR review choices - Add 🟢 Acceptable priority label for acknowledging pragmatic trade-offs - Add guidance for marking out-of-scope improvements as acceptable - Include example showing how to use the Acceptable label - Update summary to emphasize not blocking PRs for pragmatic choices Co-authored-by: openhands <openhands@all-hands.dev> * Update skills/github-pr-review/SKILL.md --------- Co-authored-by: openhands <openhands@all-hands.dev>
1 parent 3d32686 commit 444a4c3

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

skills/github-pr-review/SKILL.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,8 @@ Start each comment with a priority label. **Minimize nits** - leave minor style
7575
| 🟠 **Important** | Should fix: logic errors, performance issues, missing error handling |
7676
| 🟡 **Suggestion** | Worth considering: significant improvements to clarity or maintainability |
7777
| 🟢 **Nit** | Optional: minor style preferences (use sparingly) |
78+
| 🟢 **Acceptable** | Pragmatic choice: acknowledged trade-off that is reasonable given constraints or out of scope for this PR |
79+
7880

7981
**Example:**
8082
```
@@ -135,6 +137,7 @@ curl -X POST \
135137
1. Analyze the code and identify important issues (minimize nits)
136138
2. Post **ONE** review with all inline comments bundled
137139
3. Use priority labels (🔴🟠🟡🟢) on every comment
138-
4. Use suggestion syntax for concrete code changes
139-
5. Keep the review body brief (details go in inline comments)
140-
6. If no issues: post a short message
140+
4. Mark pragmatic trade-offs as 🟢 **Acceptable** - don't block PRs for out-of-scope improvements
141+
5. Use suggestion syntax for concrete code changes
142+
6. Keep the review body brief (details go in inline comments)
143+
7. If no issues: post a short message

0 commit comments

Comments
 (0)