Skip to content

Sayali : update bio status filter criteria to use totalValidWeeklySummaries >= 8 instead of daysInTeam > 60 #5261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sayali-2308 wants to merge 2 commits into
base: development
Choose a base branch
from
+21 −8
Open

Sayali : update bio status filter criteria to use totalValidWeeklySummaries >= 8 instead of daysInTeam > 60 #5261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24e1c6b
fix: update bio status filter criteria to use totalValidWeeklySummari…
sayali-2308 May 12, 2026
abb3391
fix: add PropTypes for totalValidWeeklySummaries and weeklySummariesC…
sayali-2308 May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions src/components/WeeklySummariesReport/BioFunction.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
/* eslint-disable no-nested-ternary */
import { useState } from 'react';
import styles from './WeeklySummariesReport.module.scss';
import ToggleSwitch from '../UserProfile/UserProfileEdit/ToggleSwitch';
import PropTypes from 'prop-types';
import styles from './WeeklySummariesReport.module.scss';

function BioFunction(props) {
const {
bioPosted,
totalTangibleHrs,
daysInTeam,
totalValidWeeklySummaries,
textColors,
summary,
bioCanEdit,
Expand All @@ -17,7 +18,8 @@ function BioFunction(props) {

const [bioStatus, setBioStatus] = useState(bioPosted);

const isMeetCriteria = totalTangibleHrs > 80 && daysInTeam > 60 && bioPosted !== 'posted';
const isMeetCriteria =
totalTangibleHrs > 80 && totalValidWeeklySummaries >= 8 && bioPosted !== 'posted';
const style = {
color: textColors[summary?.weeklySummaryOption] || textColors.Default,
};
Expand Down Expand Up @@ -54,4 +56,15 @@ function BioFunction(props) {
);
}

BioFunction.propTypes = {
bioPosted: PropTypes.string,
totalTangibleHrs: PropTypes.number,
totalValidWeeklySummaries: PropTypes.number,
textColors: PropTypes.object,
summary: PropTypes.object,
bioCanEdit: PropTypes.bool,
handleProfileChange: PropTypes.func,
userId: PropTypes.string,
};

export default BioFunction;
3 changes: 2 additions & 1 deletion src/components/WeeklySummariesReport/FormattedReport.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@
const isMeetCriteria =
canSeeBioHighlight &&
summary.totalTangibleHrs > 80 &&
summary.daysInTeam > 60 &&
summary.weeklySummariesCount >= 8 &&

Check warning on line 310 in src/components/WeeklySummariesReport/FormattedReport.jsx

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

'summary.weeklySummariesCount' is missing in props validation 


See more on https://sonarcloud.io/project/issues?id=OneCommunityGlobal_HighestGoodNetworkApp&issues=AZ4dVjg7tDLRWaKfuAjW&open=AZ4dVjg7tDLRWaKfuAjW&pullRequest=5261
summary.bioPosted !== 'posted';

return (
Expand Down Expand Up @@ -1105,6 +1105,7 @@
startDate: PropTypes.string,
endDate: PropTypes.string,
trophyFollowedUp: PropTypes.bool,
weeklySummariesCount: PropTypes.number,
timeOffFrom: PropTypes.string,
timeOffTill: PropTypes.string,
}).isRequired,
Expand Down
2 changes: 1 addition & 1 deletion src/components/WeeklySummariesReport/WeeklySummariesReport.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,7 @@ const WeeklySummariesReport = props => {

const isMeetCriteria =
summary.totalTangibleHrs > 80 &&
summary.daysInTeam > 60 &&
summary.weeklySummariesCount >= 8 &&
summary.bioPosted !== 'posted';

const isBio = !selectedBioStatus || isMeetCriteria;
Expand Down
2 changes: 1 addition & 1 deletion src/components/WeeklySummariesReport/__tests__/BioFunction.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const colors = {
const baseProps = {
bioPosted: 'default',
totalTangibleHrs: 100,
daysInTeam: 70,
totalValidWeeklySummaries: 10,
textColors: colors,
summary: { weeklySummaryOption: 'option1' },
bioCanEdit: true,
Expand Down
3 changes: 1 addition & 2 deletions src/components/WeeklySummariesReport/__tests__/FormattedReport.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ const dummySummary = {
uploadDate: moment().toISOString(),
},
],
weeklySummariesCount: '5',
weeklySummariesCount: 10,
teamCode: 'ABC123',
mediaUrl: 'http://example.com/media',
adminLinks: [{ Name: 'Media Folder', Link: 'http://example.com/folder' }],
Expand All @@ -71,7 +71,6 @@ const dummySummary = {
.add(1, 'days')
.format(),
totalTangibleHrs: 100,
daysInTeam: 70,
bioPosted: 'default',
weeklySummaryOption: 'Default',
};
Expand Down
Loading