Sayali : update bio status filter criteria to use totalValidWeeklySummaries >= 8 instead of daysInTeam > 60#5261
Open
sayali-2308 wants to merge 2 commits into
Open
Conversation
…es >= 8 instead of daysInTeam > 60
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…ount, remove duplicate in test
|
sayali-2308
added
the
High Priority - Please Review First
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1 (Priority High)
Related PRs:
Replaces PR #3529
Main changes explained:
WeeklySummariesReport.jsxto usesummary.weeklySummariesCount >= 8instead ofsummary.daysInTeam > 60inisMeetCriteriafilter logicFormattedReport.jsxsame criteria fix for bio highlight (yellow background)BioFunction.jsxto usetotalValidWeeklySummariesprop instead ofdaysInTeamBioFunction.test.jsxandFormattedReport.test.jsxto reflect new prop namesHow to test:
Sayali_Task1_BioStatus_ValidWeeklySummariesnpm install && npm run start:localScreenshots:
Note:
Frontend-only change. No backend changes required.