Fix compose scan failures#140
Open
Kurrisua wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Surface Docker Compose service scan failures in the CLI Quick take summary.
When a Compose service image or Dockerfile scan fails, DockSec previously only recorded that failure through internal logging. This could make a Compose scan look complete even when one or more services were not actually scanned.
This PR tracks failed service scans with the service name, scan type, and a short reason, returns that metadata from
ComposeOrchestrator.run_full_scan(), and renders it in the user-facing Quick take block.Closes #131
Type of Change
How Has This Been Tested?
Describe the tests run to verify the changes:
Test Configuration:
mainCommands run: