Skip to content

chore: bump NosCore.Packets to 21.0.0 and NosCore.Algorithm to 2.1.0 - #2287

Merged
erwan-joly merged 1 commit into
masterfrom
chore/bump-packets-algorithm
Aug 23, 2026
Merged

chore: bump NosCore.Packets to 21.0.0 and NosCore.Algorithm to 2.1.0#2287
erwan-joly merged 1 commit into
masterfrom
chore/bump-packets-algorithm

Conversation

@erwan-joly

@erwan-joly erwan-joly commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Consumer bump for the two releases just published.

NosCore.Packets 21.0.0 (NosCoreIO/NosCore.Packets#494, #495)

  • gidx's family id flattened from a two-field sub-packet to a nullable id, matching the client-side GidxPacket next to it and the captured wire
  • ScnPacket index 9 given the SpecialSeparator its three siblings carry
  • the sub-packet serializer patch from remove daofactory #493 reverted — it was solving a mis-modelled packet at the wrong level

Major bump because GidxFamilySubPacket was removed; nothing in NosCore referenced it, so the practical impact here is nil.

NosCore.Algorithm 2.1.0 (NosCoreIO/NosCore.Algorithm#130)

  • family experience table corrected in every row and extended from 19 to 30 levels. The old table would have asked a level 1 family for 100 000 instead of 80 000, and a family reaching 19 could not have levelled at all.

Build succeeds, 927/927 tests pass.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated centrally managed package versions to newer releases.
    • Improved compatibility with the latest algorithm and packet handling updates.

Packets 21.0.0 carries the gidx family id flattened to a nullable id, the
ScnPacket boots separator, and the reverted sub-packet serializer patch.

Algorithm 2.1.0 carries the corrected family experience table, which now runs to
level 30 instead of stopping at 19.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ed05aadf-7fbe-4fa8-83e8-f0a35e845bd6

📥 Commits

Reviewing files that changed from the base of the PR and between 34544c4 and bdc4c8c.

📒 Files selected for processing (1)
  • Directory.Packages.props

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The central package management file updates NosCore.Algorithm to 2.1.0 and NosCore.Packets to 21.0.0. Other NosCore package versions remain unchanged.

Changes

Central package version updates

Layer / File(s) Summary
Update centrally managed package versions
Directory.Packages.props
Updates NosCore.Algorithm and NosCore.Packets to their new versions.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to bdc4c

This PR updates the NosCore.Packets and NosCore.Algorithm dependencies, with the build and test suite passing; no actionable merge-blocking risk remains beyond normal review.

Suggested reviewers: denislauri1999

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies both dependency version updates described in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-packets-algorithm

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@erwan-joly
erwan-joly merged commit 55dc38c into master Aug 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant