chore: bump NosCore.Packets to 21.0.0 - #2286
Conversation
Brings the gidx family id as a nullable id, which is the shape a capture shows in all 670 of its gidx lines, and the boots slot of sc_n dotted like the other three. Builds and tests clean: nothing in this repository used GidxFamilySubPacket, so the breaking change costs nothing here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe centrally managed ChangesPackage upgrade
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates packet handling to the 21.0.0 contract for nullable family IDs and the corrected boots-slot format. Builds and tests are clean, and no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by #2287, which is already on master and bumps NosCore.Algorithm to 2.1.0 in the same change. Thanks for catching the release though — nothing lost. |
Picks up NosCoreIO/NosCore.Packets#494 and #495.
What it brings that matters here:
gidx's family id is now a nullable id, so the packet finally matches what a capture shows —gidx 1 521919 5083 [NDM](Gardien) 3with a family,gidx 1 741328 -1 - 0without. Both reproduce exactly on 21.0.0. This is what feat(family): a character's family is loaded, named, and described #2283 needs to send the family tag at all.sc_n's boots slot is dotted like the other three.Builds and tests clean — nothing in this repository referenced
GidxFamilySubPacket, so the breaking part of the major bump costs nothing.🤖 Generated with Claude Code
Summary by CodeRabbit