Skip to content

chore: bump NosCore.Packets to 21.0.0 - #2286

Closed
denislauri1999 wants to merge 1 commit into
NosCoreIO:masterfrom
denislauri1999:pr/bump-packets-21
Closed

chore: bump NosCore.Packets to 21.0.0#2286
denislauri1999 wants to merge 1 commit into
NosCoreIO:masterfrom
denislauri1999:pr/bump-packets-21

Conversation

@denislauri1999

@denislauri1999 denislauri1999 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Picks up NosCoreIO/NosCore.Packets#494 and #495.

What it brings that matters here:

  • gidx's family id is now a nullable id, so the packet finally matches what a capture shows — gidx 1 521919 5083 [NDM](Gardien) 3 with a family, gidx 1 741328 -1 - 0 without. Both reproduce exactly on 21.0.0. This is what feat(family): a character's family is loaded, named, and described #2283 needs to send the family tag at all.
  • sc_n's boots slot is dotted like the other three.

Builds and tests clean — nothing in this repository referenced GidxFamilySubPacket, so the breaking part of the major bump costs nothing.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the centrally managed packet library to version 21.0.0.
    • No user-facing features or behavior changes were introduced.

Brings the gidx family id as a nullable id, which is the shape a capture shows in all 670 of
its gidx lines, and the boots slot of sc_n dotted like the other three.

Builds and tests clean: nothing in this repository used GidxFamilySubPacket, so the breaking
change costs nothing here.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 97519b49-0e9b-4c54-b1b1-6a9e96385585

📥 Commits

Reviewing files that changed from the base of the PR and between 34544c4 and 6d19d81.

📒 Files selected for processing (1)
  • Directory.Packages.props

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The centrally managed NosCore.Packets package version was updated from 20.0.3 to 21.0.0.

Changes

Package upgrade

Layer / File(s) Summary
Update NosCore.Packets version
Directory.Packages.props
The centrally managed NosCore.Packets dependency now uses version 21.0.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 6d19d

This updates packet handling to the 21.0.0 contract for nullable family IDs and the corrected boots-slot format. Builds and tests are clean, and no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: erwan-joly

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the package version update, which is the main change in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@erwan-joly

Copy link
Copy Markdown
Collaborator

Superseded by #2287, which is already on master and bumps NosCore.Algorithm to 2.1.0 in the same change. Thanks for catching the release though — nothing lost.

@erwan-joly erwan-joly closed this Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants