[None][infra] Waive 23 failed cases for main in post-merge 2894 - #17458
Conversation
Bug(s): 6572800, 6581047, 6581048, 6581049, 6581063, 6581065, 6581066, 6581067, 6581071, 6581073, 6581075 Requested by: @mzweilz Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
/bot skip --comment "waive only" |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe integration waiver list adds 23 skip entries for newly affected model, multimodal, performance, sampler, attention precision, and FP4 GEMM tests. ChangesIntegration test waivers
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 58: Add the repository-standard NVIDIA copyright header at the top of the
modified waives.txt file, using 2026 as the latest meaningful modification year;
leave the existing test entry unchanged.
- Line 58: Add the NVIDIA copyright header to
tests/integration/test_lists/waives.txt and align its waiver entries with the PR
objectives by adding bug 6581066 if it remains in scope; otherwise remove that
objective. Preserve existing waiver entries unless they are part of this scope
adjustment.
- Line 409: Update the sampler waiver entry to target only the failing test by
replacing the broad unittest path and exclusion expression with the fully
qualified pytest node ID for test_speculative_d2h_parity_real_predictor.
Preserve the existing nvbugs reference.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 1b341110-9cd4-45ff-953d-28ff9328db26
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
PR_Github #64936 [ skip ] triggered by Bot. Commit: |
|
PR_Github #64936 [ skip ] completed with state |
Signed-off-by: Abby Wei <18545893+mzweilz@users.noreply.github.com>
|
/bot skip --comment "waive only" |
|
PR_Github #64945 [ skip ] triggered by Bot. Commit: |
|
PR_Github #64945 [ skip ] completed with state |
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @mzweilz)
Target branch:
mainBug(s): 6572800, 6581047, 6581048, 6581049, 6581063, 6581065, 6581066, 6581067, 6581071, 6581073, 6581075
Waive entries added
Already waived (skipped)
accuracy/test_llm_api_pytorch.py::TestNemotronV3Ultra::test_nvfp4_8gpus[attention_dp_off-trtllm]This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Dev Engineer Review
SKIPentries totests/integration/test_lists/waives.txt.QA Engineer Review
tests/integration/test_lists/waives.txt.test-db/orqa/files were modified.