[None][infra] Unwaive 3 perf-sanity cases verified passing on ToT - #17459
[None][infra] Unwaive 3 perf-sanity cases verified passing on ToT#17459chenfeiz0326 wants to merge 2 commits into
Conversation
|
/bot run --disable-fail-fast --stage-list "GB200-4_GPUs-PyTorch-PerfSanity-Post-Merge-*,GB200-8_GPUs-2_Nodes-PyTorch-PerfSanity-Node2-GPU8-Post-Merge-1,GB200-8_GPUs-2_Nodes-PyTorch-PerfSanity-Node2-GPU8-Post-Merge-3,GB300-8_GPUs-2_Nodes-PyTorch-PerfSanity-Node2-GPU8-Post-Merge-1" |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe pull request increases the aggregated-server readiness timeout from 1800 to 3600 seconds. It also removes several performance-test waivers and adds GLM5 context-only waivers. ChangesPerformance test configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #64938 [ run ] triggered by Bot. Commit: |
|
PR_Github #64938 [ run ] completed with state
|
Correction on the v4-pro case (not unwaived here)My description above understated how healthy the v4-pro run actually is, so to be accurate: Under ( So the workload is functionally fine. Both obstacles are harness-level:
Whether (2) reproduces in Jenkins is open — a shm bus error is also what a container Neither point affects the three cases this PR unwaives; they were verified independently and CI-faithfully. |
v4-pro ctx_only verified passing under this PR (aws-cmh GB300, job 2944440)Re-ran the case with
Both blockers on nvbugs/6517846 are therefore cleared:
This PR now unwaives all 4 cases originally in the cohort. |
|
/bot run --disable-fail-fast --stage-list "GB200-4_GPUs-PyTorch-PerfSanity-Post-Merge-,GB200-8_GPUs-2_Nodes-PyTorch-PerfSanity-Node2-GPU8-Post-Merge-1,GB200-8_GPUs-2_Nodes-PyTorch-PerfSanity-Node2-GPU8-Post-Merge-3,GB300-8_GPUs-2_Nodes-PyTorch-PerfSanity-Node2-GPU8-Post-Merge-1,GB300-4_GPUs-PyTorch-PerfSanity-Post-Merge-" |
Re-ran the following aggregated perf-sanity cases on current ToT and all three pass end to end, so their waives are stale: | case | job | result | requests | |---|---|---|---| | deepseek_r1_fp4_v2_2_nodes_grace_blackwell-r1_fp4_v2_dep8_mtp1_8k1k | 2929320 | 1 passed in 1386.44s | 10240/10240 ok | | k25_thinking_fp4_2_nodes_grace_blackwell-k25_thinking_fp4_tep8_32k8k | 2929336 | 1 passed in 689.88s | 10/10 ok | | deepseek_r1_fp4_v2_grace_blackwell-r1_fp4_v2_dep4_mtp1_1k8k | 2929319 | 1 passed in 4879.88s | 10240/10240 ok | All three ran CI-faithful (no server-readiness override), finished COMPLETED 0:0 with the launcher's own "Aggregated test completed successfully" line, every MPI rank exiting 0, no bus errors, and report.xml tests=1 failures=0 errors=0 skipped=0. Bug status: nvbugs/6422339 (cases 2 and 3) is already Dev - Closed - Verified. nvbugs/6530213 (case 1) is still open, but the case passes on ToT, so the waive is stale regardless. The fourth case in this cohort, ctx_only-gb300_deepseek-v4-pro-fp4_8k1k_con4301_..._ccb-NIXL (nvbugs/6517846), is deliberately left waived: it still fails, for two independent reasons (server needs ~2000s to become ready vs the 1800s AGG cap, and the MPI worker ranks SIGBUS during teardown even after the benchmark completes). Signed-off-by: chenfeiz0326 <203214996+chenfeiz0326@users.noreply.github.com>
… and unwaive v4-pro ctx_only The gb300 DeepSeek-V4-Pro ctx_only case (con4301) needs ~2000s of model load + autotune before /health answers, but AGG_SERVER_READY_TIMEOUT was 1800s, so it failed readiness while the server was still coming up. The per-case test-db TIMEOUT annotation cannot help, because the wait is computed as min(self.timeout, server_ready_timeout(...)). Raise the agg bound to 3600s, matching the disagg bound, and unwaive the case. Verified on aws-cmh GB300 with the equivalent env override (TRTLLM_TEST_AGG_SERVER_READY_TIMEOUT=3600): the server becomes ready, zero readiness timeouts, and the benchmark completes with 43010/43010 successful requests, 0 failed, 62530.98 tok/s total token throughput. Signed-off-by: chenfeiz0326 <203214996+chenfeiz0326@users.noreply.github.com>
a073cb5 to
6c50743
Compare
|
Rebased onto The conflict was purely positional. Three upstream commits churned the same region of Resolution kept every upstream line and dropped only the four this PR intends to unwaive. Verified post-rebase:
No re-verification run is needed: the rebase changed no test code, and the aws-cmh GB300 verification above already exercised the exact /bot run --disable-fail-fast --stage-list "GB200-4_GPUs-PyTorch-PerfSanity-Post-Merge-,GB200-8_GPUs-2_Nodes-PyTorch-PerfSanity-Node2-GPU8-Post-Merge-1,GB200-8_GPUs-2_Nodes-PyTorch-PerfSanity-Node2-GPU8-Post-Merge-3,GB300-8_GPUs-2_Nodes-PyTorch-PerfSanity-Node2-GPU8-Post-Merge-1,GB300-4_GPUs-PyTorch-PerfSanity-Post-Merge-" |
|
/bot skip --comment "Only unwaive perf tests, no need to run the whole CI pipeline" |
|
PR_Github #65021 [ skip ] triggered by Bot. Commit: |
|
PR_Github #65021 [ skip ] completed with state |
Summary
Three aggregated perf-sanity cases in
tests/integration/test_lists/waives.txtwere re-run on current ToT and all three pass end to end. Their waives are stale, so this PR removes them.aggr_upload-deepseek_r1_fp4_v2_2_nodes_grace_blackwell-r1_fp4_v2_dep8_mtp1_8k1k1 passed in 1386.44saggr_upload-k25_thinking_fp4_2_nodes_grace_blackwell-k25_thinking_fp4_tep8_32k8k1 passed in 689.88snum_prompts=10, max_concurrency=2)aggr_upload-deepseek_r1_fp4_v2_grace_blackwell-r1_fp4_v2_dep4_mtp1_1k8k1 passed in 4879.88sVerification for each run, all CI-faithful (no server-readiness env override):
1 passedreport.xml:tests="1" failures="0" errors="0" skipped="0"(executed, not deselected)sacct:COMPLETED 0:0Aggregated test completed successfullyBus erroroccurrences<run_dir>/aggr-*/trtllm-benchmark.*.logBug status
nvbugs/6422339(cases 2 and 3) is already Dev - Closed - Verified (fixed 2026-07-20) — cleanly stale waives.nvbugs/6530213(case 1) is still Dev - Open - To fix, but the case passes on ToT, so the waive is stale regardless.Deliberately NOT unwaived
aggr_upload-ctx_only-gb300_deepseek-v4-pro-fp4_8k1k_con4301_ctx12_dep4_gen1_dep8_eplb384_mtp1_ccb-NIXL(nvbugs/6517846) stays waived. It still fails, for two independent reasons:/health(8xCache size after warmup, autotune finishing ~35 min in), buttest_perf_sanity.pyclamps readiness tomin(self.timeout, AGG_SERVER_READY_TIMEOUT=1800), so the per-caseTIMEOUTannotation cannot help. Run 2929124:1 failed ... in 1802.20swith 4xdid not become ready within 1800 seconds.TRTLLM_TEST_AGG_SERVER_READY_TIMEOUT=3600, pytest reports1 passed ... in 7116.39sand the job still fails: all three peermgmn_worker_noderanks hitSignal: Bus error (7) / Non-existant physical address-> exit 135, sosrun --kill-on-bad-exit=1returns non-zero and the launcher'scleanup_on_failurefails the stage (Error: Aggregated test failed).Both belong to the existing bug, not to this PR.
Test Coverage
The three unwaived cases are re-enabled in these post-merge stages, which will run pre-merge on this PR:
GB200-4_GPUs-PyTorch-PerfSanity-Post-Merge-*(caser1_fp4_v2_dep4_mtp1_1k8k)GB200-8_GPUs-2_Nodes-PyTorch-PerfSanity-Node2-GPU8-Post-Merge-1/-3GB300-8_GPUs-2_Nodes-PyTorch-PerfSanity-Node2-GPU8-Post-Merge-1Note the verification runs above were executed on GB300 (
supported_gpusis advisory in perf-sanity and is never read bytest_perf_sanity.py), so the GB200 stages in the list above are what confirm the GB200 hardware path.PR Checklist
Dev Engineer Review
tests/integration/test_lists/waives.txt.AGG_SERVER_READY_TIMEOUTfrom 1800 to 3600 seconds.ci: full pre-merge approvedlabel was missing.QA Engineer Review
test-db/orqa/files were modified.AGG_SERVER_READY_TIMEOUTintests/integration/defs/perf/test_perf_sanity.py.tests/integration/test_lists/waives.txt.