Skip to content

docs(datadog): document the batches_saved queue metric - #12231

Merged
mergify[bot] merged 1 commit into
mainfrom
devs/jd/jd/mrgfy-8213-product-change-watcher-docs-follow-the-product/document-batches-saved-queue-metric--4d81d0e0
Jul 28, 2026
Merged

docs(datadog): document the batches_saved queue metric#12231
mergify[bot] merged 1 commit into
mainfrom
devs/jd/jd/mrgfy-8213-product-change-watcher-docs-follow-the-product/document-batches-saved-queue-metric--4d81d0e0

Conversation

@jd

@jd jd commented Jul 27, 2026

Copy link
Copy Markdown
Member

The metrics reference was missing
mergify.queue.skip_intermediate_results.batches_saved, a count the engine's
stats metrics pusher has been submitting alongside the rest of the
mergify.queue.* family. It is what backs the "Batches Saved" chart on the
merge queue Statistics page.

Add the table row and a short paragraph explaining what it counts and that it
only moves when skip_intermediate_results is enabled. The explanation goes in
prose rather than the table cell because a metric name that long plus an inline
link exceeds the 120-character line limit, and table rows cannot be wrapped.

MRGFY-8213

Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com

Depends-On: #12230

@mergify
mergify Bot had a problem deploying to Mergify Merge Protections July 27, 2026 14:16 Failure
@jd

jd commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 docs(merge-queue): partition_rules are removed, not deprecated #12230
2 docs(datadog): document the batches_saved queue metric #12231 👈
3 docs(merge-queue): describe the Statistics page as it ships #12232
4 docs(merge-protections): show where Depends-On surfaces in the queue #12233

@mergify

mergify Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 7 merge protections satisfied — ready to merge.

Show 7 satisfied protections

🟢 ⛓️ Depends-On Requirements

Requirement based on the presence of Depends-On in the body of the pull request

🟢 🤖 Continuous Integration

  • all of:
    • check-success = build
    • check-success = lint
    • check-success = test
    • any of:
      • check-success = test-broken-links
      • label = ignore-broken-links
    • any of:
      • check-success=Cloudflare Pages
      • -head-repo-full-name~=^Mergifyio/

🟢 👀 Review Requirements

  • any of:
    • #approved-reviews-by >= 2
    • author = dependabot[bot]
    • author = mergify-ci-bot

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:

🟢 🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

  • body ~= (?ms:.{48,})

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

@mergify
mergify Bot requested a review from a team July 27, 2026 14:18
The metrics reference was missing
`mergify.queue.skip_intermediate_results.batches_saved`, a count the engine's
stats metrics pusher has been submitting alongside the rest of the
`mergify.queue.*` family. It is what backs the "Batches Saved" chart on the
merge queue Statistics page.

Add the table row and a short paragraph explaining what it counts and that it
only moves when `skip_intermediate_results` is enabled. The explanation goes in
prose rather than the table cell because a metric name that long plus an inline
link exceeds the 120-character line limit, and table rows cannot be wrapped.

MRGFY-8213

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Change-Id: I4d81d0e0cc1ddea0fde7ca8a469bb99570a7db11
@jd
jd force-pushed the devs/jd/jd/mrgfy-8213-product-change-watcher-docs-follow-the-product/document-batches-saved-queue-metric--4d81d0e0 branch from f30ab27 to eae3547 Compare July 27, 2026 14:30
@jd
jd force-pushed the devs/jd/jd/mrgfy-8213-product-change-watcher-docs-follow-the-product/partition-rules-removed-deprecated--5a5aeb9e branch from 214b594 to 6a5cbfd Compare July 27, 2026 14:30
@jd

jd commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

Revision history

# Type Changes Reason Date
1 initial f30ab27 2026-07-27 14:30 UTC
2 rebase f30ab27 → eae3547 (rebase only) 2026-07-27 14:30 UTC

@mergify
mergify Bot had a problem deploying to Mergify Merge Protections July 27, 2026 14:30 Failure
@jd
jd marked this pull request as ready for review July 28, 2026 08:17
Base automatically changed from devs/jd/jd/mrgfy-8213-product-change-watcher-docs-follow-the-product/partition-rules-removed-deprecated--5a5aeb9e to main July 28, 2026 08:26
@mergify
mergify Bot force-pushed the devs/jd/jd/mrgfy-8213-product-change-watcher-docs-follow-the-product/document-batches-saved-queue-metric--4d81d0e0 branch from eae3547 to 67c125e Compare July 28, 2026 08:26
@mergify
mergify Bot deployed to Mergify Merge Protections July 28, 2026 08:26 Active
@mergify
mergify Bot requested a review from a team July 28, 2026 08:56
@mergify

mergify Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 2 minutes 37 seconds in the queue, including 2 minutes 4 seconds running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Jul 28, 2026
@mergify
mergify Bot merged commit 3703c87 into main Jul 28, 2026
10 checks passed
@mergify
mergify Bot deleted the devs/jd/jd/mrgfy-8213-product-change-watcher-docs-follow-the-product/document-batches-saved-queue-metric--4d81d0e0 branch July 28, 2026 09:19
@mergify mergify Bot removed the queued label Jul 28, 2026
mergify Bot pushed a commit that referenced this pull request Jul 28, 2026
"Monitoring your Merge Queue" listed six freeform metrics that no longer line up
with the dashboard. The Statistics page groups its widgets into Queue Health,
Throughput and Performance under a row of headline figures, and gained two
things this quarter the page never mentioned: the Time Breakdown widget's
Avg/P95/Max selector, and the Batches Saved chart.

Rewrite the section to follow the page: every widget by its real name, what it
tells you, and the reference-line semantics for Max Queue Size (max batch size
times max_parallel_checks) and Average Batch Size (the largest configured
batch_size). The Time Breakdown entry explains the selector and why the center
total only appears for the average: p95 and max of the components are not
additive.

Also correct the retention claim while it moves. The "Past 3 months" preset
spans roughly 91 to 92 days against 90 days of queue-event retention, so its
oldest day or two come back empty; the page promised that every preset returned
complete data.

MRGFY-8213

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Depends-On: #12231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants