Skip to content

docs(merge-queue): partition_rules are removed, not deprecated - #12230

Merged
mergify[bot] merged 1 commit into
mainfrom
devs/jd/jd/mrgfy-8213-product-change-watcher-docs-follow-the-product/partition-rules-removed-deprecated--5a5aeb9e
Jul 28, 2026
Merged

docs(merge-queue): partition_rules are removed, not deprecated#12230
mergify[bot] merged 1 commit into
mainfrom
devs/jd/jd/mrgfy-8213-product-change-watcher-docs-follow-the-product/partition-rules-removed-deprecated--5a5aeb9e

Conversation

@jd

@jd jd commented Jul 27, 2026

Copy link
Copy Markdown
Member

The migration guide still told readers partition_rules were "deprecated and
will be removed in a future release". They are already gone: the key is absent
from public/mergify-configuration-schema.json and from the engine's
configuration model, having disappeared between the 2026-06-02 and 2026-06-12
schema syncs with no changelog entry.

Describe what actually happens now. The configuration model allows extra keys,
so a file still declaring partition_rules is not rejected: Mergify ignores the
section, the queue stops splitting into partition lanes, and the extra-keys
transformer opens a configuration migration pull request that strips it out.
Step 3 notes that merging that pull request does the work for you.

In queue-modes, partition_rules was listed as an isolated-mode limitation. It
is not mode-specific any more, so it moves out of the limitations list into a
sentence pointing at the migration guide.

MRGFY-8213

Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com

Copilot AI review requested due to automatic review settings July 27, 2026 14:16
@mergify
mergify Bot had a problem deploying to Mergify Merge Protections July 27, 2026 14:16 Failure
@jd

jd commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 docs(merge-queue): partition_rules are removed, not deprecated #12230 👈
2 docs(datadog): document the batches_saved queue metric #12231
3 docs(merge-queue): describe the Statistics page as it ships #12232
4 docs(merge-protections): show where Depends-On surfaces in the queue #12233

@mergify

mergify Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 6 merge protections satisfied — ready to merge.

Show 6 satisfied protections

🟢 🤖 Continuous Integration

  • all of:
    • check-success = build
    • check-success = lint
    • check-success = test
    • any of:
      • check-success = test-broken-links
      • label = ignore-broken-links
    • any of:
      • check-success=Cloudflare Pages
      • -head-repo-full-name~=^Mergifyio/

🟢 👀 Review Requirements

  • any of:
    • #approved-reviews-by >= 2
    • author = dependabot[bot]
    • author = mergify-ci-bot

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:

🟢 🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

  • body ~= (?ms:.{48,})

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates merge-queue documentation to reflect that partition_rules have already been removed (not merely deprecated), and explains current behavior/migration guidance so readers aren’t misled by outdated deprecation language.

Changes:

  • Updates Queue modes docs to state partition_rules are no longer supported in any mode and points readers to the migration guide.
  • Updates the migration guide intro to describe the current behavior when partition_rules are still present (ignored + migration PR).
  • Adds a note that merging the auto-opened migration PR can perform the removal step for you.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/content/docs/merge-queue/queue-modes.mdx Replaces the mode-specific limitation blurb with a mode-independent note + link to migration guide.
src/content/docs/merge-queue/migrate-partitions-to-scopes.mdx Rewords the guide to reflect removal (not deprecation) and clarifies the migration PR behavior.
Comments suppressed due to low confidence (1)

src/content/docs/merge-queue/migrate-partitions-to-scopes.mdx:184

  • For consistency with other pages that mention Mergify-created config updates, prefer “automatic migration pull request” over “configuration migration pull request”.
If Mergify has already opened a configuration migration pull request for your
repository, merging it does this step for you.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/content/docs/merge-queue/migrate-partitions-to-scopes.mdx Outdated
@mergify
mergify Bot requested a review from a team July 27, 2026 14:20
The migration guide still told readers `partition_rules` were "deprecated and
will be removed in a future release". They are already gone: the key is absent
from `public/mergify-configuration-schema.json` and from the engine's
configuration model, having disappeared between the 2026-06-02 and 2026-06-12
schema syncs with no changelog entry.

Describe what actually happens now. The configuration model allows extra keys,
so a file still declaring `partition_rules` is not rejected: Mergify ignores the
section, the queue stops splitting into partition lanes, and the extra-keys
transformer opens a configuration migration pull request that strips it out.
Step 3 notes that merging that pull request does the work for you.

In queue-modes, `partition_rules` was listed as an isolated-mode limitation. It
is not mode-specific any more, so it moves out of the limitations list into a
sentence pointing at the migration guide.

MRGFY-8213

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Change-Id: I5a5aeb9e975a6ec6e7ab15943d930c54023e1a70
@jd
jd force-pushed the devs/jd/jd/mrgfy-8213-product-change-watcher-docs-follow-the-product/partition-rules-removed-deprecated--5a5aeb9e branch from 214b594 to 6a5cbfd Compare July 27, 2026 14:30
@jd

jd commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

Revision history

# Type Changes Reason Date
1 initial 214b594 2026-07-27 14:30 UTC
2 content 214b594 → 6a5cbfd address review: use the corpus term "automatic migration pull request" (rules.mdx, auto-merge.mdx) instead of introducing a third variant 2026-07-27 14:30 UTC

@mergify
mergify Bot deployed to Mergify Merge Protections July 27, 2026 14:30 Active
@jd
jd marked this pull request as ready for review July 28, 2026 08:16
@mergify
mergify Bot requested a review from a team July 28, 2026 08:19
@mergify

mergify Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 2 minutes 43 seconds in the queue, including 2 minutes 11 seconds running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Jul 28, 2026
@mergify
mergify Bot merged commit 15ae091 into main Jul 28, 2026
10 of 17 checks passed
@mergify
mergify Bot deleted the devs/jd/jd/mrgfy-8213-product-change-watcher-docs-follow-the-product/partition-rules-removed-deprecated--5a5aeb9e branch July 28, 2026 08:26
@mergify mergify Bot removed the queued label Jul 28, 2026
mergify Bot pushed a commit that referenced this pull request Jul 28, 2026
The metrics reference was missing
`mergify.queue.skip_intermediate_results.batches_saved`, a count the engine's
stats metrics pusher has been submitting alongside the rest of the
`mergify.queue.*` family. It is what backs the "Batches Saved" chart on the
merge queue Statistics page.

Add the table row and a short paragraph explaining what it counts and that it
only moves when `skip_intermediate_results` is enabled. The explanation goes in
prose rather than the table cell because a metric name that long plus an inline
link exceeds the 120-character line limit, and table rows cannot be wrapped.

MRGFY-8213

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Depends-On: #12230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants