Skip to content

fix(mobile): preserve paired host over local runtime#130

Closed
riverpilot wants to merge 2 commits into
LycaonLLC:mainfrom
riverpilot:fix/pr-128-endpoint-precedence
Closed

fix(mobile): preserve paired host over local runtime#130
riverpilot wants to merge 2 commits into
LycaonLLC:mainfrom
riverpilot:fix/pr-128-endpoint-precedence

Conversation

@riverpilot

Copy link
Copy Markdown
Contributor

Summary

Supersedes #128.

Screenshots

No visual change.

Testing

  • GitHub Flutter Apple and verify checks required; Flutter is unavailable on the local workstation

Risk

  • Endpoint precedence changes only when a bundled fallback is configured.

Notes

  • Rebased on current main.

AI Review Report

Security Audit

  • Preserves explicit paired-host selection; no credential or transport changes.

@iarbpairs

Copy link
Copy Markdown
Collaborator

Architecture review: the bundled Local runtime direction and paired-host precedence are correct, but merge is intentionally held until Gate 1 freezes the common Local/Hub endpoint-profile and provider contracts. After Gate 1, rebase this contribution onto current main, preserve explicit paired-host precedence, and express the bundled fallback through the frozen profile contract. #131 also overlaps apps/flutter/lib/main.dart, so resolve that during the post-Gate-1 rebase.

@riverpilot
riverpilot force-pushed the fix/pr-128-endpoint-precedence branch from a8ecf9f to 9e11c9f Compare July 22, 2026 03:23
@riverpilot

Copy link
Copy Markdown
Contributor Author

Rebased the replacement onto current main at 551bdfa, including merged #131, and resolved the apps/flutter/lib/main.dart overlap while preserving explicit development endpoint → paired host → bundled local fallback precedence. Focused host-service tests pass (331 tests) and the release consistency check passes. The requested Gate 1 Local/Hub endpoint-profile/provider contract is not present on current main yet—the available Flutter HostProfile contract is still Tailnet-only—so I have intentionally not invented a competing profile abstraction. This PR remains held for the Gate 1 contract freeze; once that lands, I will route the bundled fallback through it and rerun Flutter CI. Packaging tests were 49/50 locally; the sole failure requires prebuilt desktop/web/host artifacts absent from this fresh worktree.

@wolfiesch

Copy link
Copy Markdown
Collaborator

Superseded by the approved Electron standardization direction. This change is coupled to the Flutter macOS runtime path and does not reproduce an independent Electron/React compatibility defect. Any host-policy issue will be recovered separately with a focused reproduction.

@wolfiesch wolfiesch closed this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants