feat: launch bundled runtime from Flutter macOS#128
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
riverpilot
left a comment
There was a problem hiding this comment.
Merge blocker: the bundled local endpoint is passed as developmentEndpoint. _connectCurrent treats every non-null development endpoint as an unconditional override and never loads/selects a saved paired host, so macOS users can persist a remote host but can never connect to it afterward. Keep bundled-local discovery distinct from the development override and preserve explicit host selection/authentication. Add a regression covering local bootstrap followed by remote host selection, then rebase current main (#127 overlap) and rerun Flutter Apple + verify.
|
Implemented the requested endpoint-precedence repair, added regression coverage, rebased the complete contribution onto current main, and opened #130 as the mergeable replacement. Please close this superseded branch. |
|
Closing as superseded by #130, which preserves paired-host precedence and rebases the complete contribution onto current main. The replacement will remain gated on the Gate 1 endpoint-profile contract before merge. |
Summary
Verification
pnpm checkpnpm testpnpm test:packagingMerge note
This changes the embedded runtime signing boundary, so it is ready for review but should receive explicit maintainer review before merge.