-
Notifications
You must be signed in to change notification settings - Fork 103
feat(infobox): add input and camera fields for players #7321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SobakaPirat
wants to merge
5
commits into
Liquipedia:main
Choose a base branch
from
SobakaPirat:trackmania-person-infobox
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+47
−2
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
597df93
feat(infobox): add input and camera fields for players
SobakaPirat b08eb52
change nilOr to nilIfEmpty
SobakaPirat 24d5e9d
clean up imports
SobakaPirat 33233b8
remove recurring imports
SobakaPirat e73d675
remove aliases
SobakaPirat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -8,6 +8,7 @@ | |||||
| local Lua = require('Module:Lua') | ||||||
|
|
||||||
| local Class = Lua.import('Module:Class') | ||||||
| local Logic = Lua.import('Module:Logic') | ||||||
|
|
||||||
| local Achievements = Lua.import('Module:Infobox/Extension/Achievements') | ||||||
| local Injector = Lua.import('Module:Widget/Injector') | ||||||
|
|
@@ -16,6 +17,25 @@ local Player = Lua.import('Module:Infobox/Person') | |||||
| local Widgets = Lua.import('Module:Widget/All') | ||||||
| local Cell = Widgets.Cell | ||||||
|
|
||||||
| ---@type table<string, string> | ||||||
| local INPUTS = { | ||||||
| gamepad = 'Gamepad', | ||||||
| joystick = 'Joystick', | ||||||
| kbm = 'Keyboard & Mouse', | ||||||
| keyboard = 'Keyboard', | ||||||
| wheel = 'Wheel', | ||||||
| } | ||||||
|
|
||||||
| ---@type table<string, string> | ||||||
| local CAMERAS = { | ||||||
| ['1'] = '1', | ||||||
| ['2'] = '2', | ||||||
| ['3'] = '3', | ||||||
| ['alt1'] = '1 (Alternate)', | ||||||
| ['alt2'] = '2 (Alternate)', | ||||||
| ['alt3'] = '3 (Alternate)', | ||||||
| } | ||||||
|
|
||||||
| ---@class TrackmaniaInfoboxPlayer: Person | ||||||
| local CustomPlayer = Class.new(Player) | ||||||
| local CustomInjector = Class.new(Injector) | ||||||
|
|
@@ -35,11 +55,36 @@ end | |||||
| ---@param widgets Widget[] | ||||||
| ---@return Widget[] | ||||||
| function CustomInjector:parse(id, widgets) | ||||||
| if id == 'status' then | ||||||
| table.insert(widgets, Cell{name = 'Years Active (Player)', children = {self.caller.args.years_active}}) | ||||||
| local caller = self.caller | ||||||
| local args = caller.args | ||||||
| if id == 'custom' then | ||||||
| table.insert(widgets, Cell{name = 'Input Device', children = {caller:formatInput()}}) | ||||||
| table.insert(widgets, Cell{name = 'Main Camera', children = {caller:formatCamera()}}) | ||||||
| elseif id == 'status' then | ||||||
| table.insert(widgets, Cell{name = 'Years Active (Player)', children = {args.years_active}}) | ||||||
| end | ||||||
|
|
||||||
| return widgets | ||||||
| end | ||||||
|
|
||||||
| ---@param lpdbData table | ||||||
| ---@return table | ||||||
| function CustomPlayer:adjustLPDB(lpdbData) | ||||||
| lpdbData.extradata.input = self:formatInput() | ||||||
| lpdbData.extradata.camera = self:formatCamera() | ||||||
| return lpdbData | ||||||
| end | ||||||
|
|
||||||
| ---@return string? | ||||||
| function CustomPlayer:formatInput() | ||||||
| local lowercaseInput = self.args.input and self.args.input:lower() or nil | ||||||
| return Logic.nilIfEmpty(INPUTS[lowercaseInput]) | ||||||
| end | ||||||
|
|
||||||
| ---@return string? | ||||||
| function CustomPlayer:formatCamera() | ||||||
| local lowercaseCamera = self.args.camera and self.args.camera:lower() or nil | ||||||
| return Logic.nilIfEmpty(CAMERAS[lowercaseCamera]) | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| end | ||||||
|
|
||||||
| return CustomPlayer | ||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should not be necessary