feat(infobox): add input and camera fields for players#7321
feat(infobox): add input and camera fields for players#7321SobakaPirat wants to merge 5 commits intoLiquipedia:mainfrom
Conversation
ElectricalBoy
left a comment
There was a problem hiding this comment.
- was this discussed with other trackmania contributors?
- do we want to add more lines to infobox?
|
personally opposed to adding such irrelevant stuff to a already way to long person infobox |
|
It was discussed in the TM channel, yes |
Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com>
Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com>
|
No one objects against these fields. In fact, it's an idea of two other contributors, not mine.
Why is it irrelevant? Do you have other options there we can show this info? |
| ---@return string? | ||
| function CustomPlayer:formatInput() | ||
| local lowercaseInput = self.args.input and self.args.input:lower() or nil | ||
| return Logic.nilIfEmpty(INPUTS[lowercaseInput]) |
There was a problem hiding this comment.
| return Logic.nilIfEmpty(INPUTS[lowercaseInput]) | |
| return INPUTS[lowercaseInput] |
should not be necessary
| ---@return string? | ||
| function CustomPlayer:formatCamera() | ||
| local lowercaseCamera = self.args.camera and self.args.camera:lower() or nil | ||
| return Logic.nilIfEmpty(CAMERAS[lowercaseCamera]) |
There was a problem hiding this comment.
| return Logic.nilIfEmpty(CAMERAS[lowercaseCamera]) | |
| return CAMERAS[lowercaseCamera] |
The player infobox on TM is not that long (unless there's a very long team history, but then we plan to move these somewhere else eventually anyway) |
|
tend to agree with hjp; I don't think this information is relevant to infoboxes |
|
Just to be consistent, I would also say this info belong to a different place on the player page, like a separate table like counterstrike does it: https://liquipedia.net/counterstrike/NAF I haven't really seen infobox being used for this type of information elsewhere |
Co-authored-by: SyntacticSalt <mbergent@uni-bremen.de>
Summary
'Input device' and 'main camera' fields for trackmania player infobox with lpdb storage
How did you test this change?
https://liquipedia.net/trackmania/Sandbox/SobakaPirat