Skip to content

feat(infobox): add input and camera fields for players#7321

Open
SobakaPirat wants to merge 5 commits intoLiquipedia:mainfrom
SobakaPirat:trackmania-person-infobox
Open

feat(infobox): add input and camera fields for players#7321
SobakaPirat wants to merge 5 commits intoLiquipedia:mainfrom
SobakaPirat:trackmania-person-infobox

Conversation

@SobakaPirat
Copy link
Copy Markdown
Contributor

@SobakaPirat SobakaPirat commented Mar 30, 2026

Summary

'Input device' and 'main camera' fields for trackmania player infobox with lpdb storage

How did you test this change?

https://liquipedia.net/trackmania/Sandbox/SobakaPirat

@SobakaPirat SobakaPirat requested review from a team as code owners March 30, 2026 22:13
Copy link
Copy Markdown
Collaborator

@ElectricalBoy ElectricalBoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • was this discussed with other trackmania contributors?
  • do we want to add more lines to infobox?

@hjpalpha
Copy link
Copy Markdown
Collaborator

personally opposed to adding such irrelevant stuff to a already way to long person infobox

@mbergen
Copy link
Copy Markdown
Collaborator

mbergen commented Mar 31, 2026

It was discussed in the TM channel, yes

SobakaPirat and others added 3 commits March 31, 2026 15:36
Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com>
Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com>
@SobakaPirat
Copy link
Copy Markdown
Contributor Author

No one objects against these fields. In fact, it's an idea of two other contributors, not mine.

personally opposed to adding such irrelevant stuff to a already way to long person infobox

Why is it irrelevant? Do you have other options there we can show this info?

---@return string?
function CustomPlayer:formatInput()
local lowercaseInput = self.args.input and self.args.input:lower() or nil
return Logic.nilIfEmpty(INPUTS[lowercaseInput])
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return Logic.nilIfEmpty(INPUTS[lowercaseInput])
return INPUTS[lowercaseInput]

should not be necessary

---@return string?
function CustomPlayer:formatCamera()
local lowercaseCamera = self.args.camera and self.args.camera:lower() or nil
return Logic.nilIfEmpty(CAMERAS[lowercaseCamera])
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return Logic.nilIfEmpty(CAMERAS[lowercaseCamera])
return CAMERAS[lowercaseCamera]

@mbergen
Copy link
Copy Markdown
Collaborator

mbergen commented Apr 2, 2026

personally opposed to adding such irrelevant stuff to a already way to long person infobox

The player infobox on TM is not that long (unless there's a very long team history, but then we plan to move these somewhere else eventually anyway)

@ElectricalBoy
Copy link
Copy Markdown
Collaborator

tend to agree with hjp; I don't think this information is relevant to infoboxes
I am not opposed to having this type of information on pages (like how some other wikis keep track of e.g., mouse sensitivity) but infobox just feels like a wrong place to put that information

@Eetwalt
Copy link
Copy Markdown
Collaborator

Eetwalt commented Apr 2, 2026

Just to be consistent, I would also say this info belong to a different place on the player page, like a separate table like counterstrike does it: https://liquipedia.net/counterstrike/NAF

I haven't really seen infobox being used for this type of information elsewhere

Co-authored-by: SyntacticSalt <mbergent@uni-bremen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants