Skip to content

Improve incl_same_name #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fantazio wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve incl_same_name #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions check/classic/classic.exp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,19 @@
./examples/docs/exported_values/hello_world/hello_world_with_intf.mli:3: goodbye
./examples/docs/exported_values/hello_world/hello_world_with_intf.mli:4: world

./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/with_intf.mli:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/without_intf.mli:4: redefined_unused

./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/with_intf.ml:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/without_intf.ml:4: redefined_unused

./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:2: unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:5: redefined_used
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:2: unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:5: redefined_used

./examples/docs/methods/code_constructs/factory_fun/factory_fun_bin.ml:2: unused_factory

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:2: unused_obj
Expand Down
27 changes: 20 additions & 7 deletions check/classic/classic.ref
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,23 @@
./examples/docs/exported_values/hello_world/hello_world_with_intf.mli:3: goodbye
./examples/docs/exported_values/hello_world/hello_world_with_intf.mli:4: world

./examples/docs/exported_values/limitations/incl_same_name/oo.mli:20: copy: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/oo.mli:25: id: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/oo.mli:40: new_method: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/oo.mli:41: public_method_label: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/with_intf.mli:2: unused: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/with_intf.mli:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/without_intf.ml:2: unused: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/without_intf.mli:4: redefined_unused

./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/with_intf.ml:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/with_intf.mli:2: unused: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/without_intf.ml:2: unused: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/without_intf.ml:4: redefined_unused

./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:2: unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:5: redefined_used
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:2: unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:5: redefined_used

./examples/docs/methods/code_constructs/factory_fun/factory_fun_bin.ml:2: unused_factory

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:2: unused_obj
Expand Down Expand Up @@ -768,7 +781,7 @@ Nothing else to report in this section
--------------------------------------------------------------------------------


Total: 643
Success: 585
Total: 653
Success: 595
Failed: 58
Ratio: 90.9797822706%
Ratio: 91.1179173047%
13 changes: 13 additions & 0 deletions check/internal/internal.exp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,19 @@

./examples/docs/exported_values/code_constructs/module/module_lib.mli:6: M.unused

./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/with_intf.mli:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/without_intf.mli:4: redefined_unused

./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/with_intf.ml:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/without_intf.ml:4: redefined_unused

./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:2: unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:5: redefined_used
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:2: unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:5: redefined_used

./examples/docs/methods/code_constructs/factory_fun/factory_fun_bin.ml:2: unused_factory

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:2: unused_obj
Expand Down
27 changes: 20 additions & 7 deletions check/internal/internal.ref
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,23 @@

./examples/docs/exported_values/code_constructs/module/module_lib.mli:6: M.unused

./examples/docs/exported_values/limitations/incl_same_name/oo.mli:20: copy: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/oo.mli:25: id: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/oo.mli:40: new_method: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/oo.mli:41: public_method_label: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/with_intf.mli:2: unused: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/with_intf.mli:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/without_intf.ml:2: unused: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/without_intf.mli:4: redefined_unused

./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/with_intf.ml:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/with_intf.mli:2: unused: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/without_intf.ml:2: unused: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/without_intf.ml:4: redefined_unused

./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:2: unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:5: redefined_used
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:2: unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:5: redefined_used

./examples/docs/methods/code_constructs/factory_fun/factory_fun_bin.ml:2: unused_factory

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:2: unused_obj
Expand Down Expand Up @@ -720,7 +733,7 @@ Nothing else to report in this section
--------------------------------------------------------------------------------


Total: 599
Success: 541
Total: 609
Success: 551
Failed: 58
Ratio: 90.3171953255%
Ratio: 90.4761904762%
22 changes: 22 additions & 0 deletions check/threshold-1/threshold-1.exp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,19 @@

./examples/docs/exported_values/code_constructs/module/module_lib.mli:6: M.unused

./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/with_intf.mli:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/without_intf.mli:4: redefined_unused

./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/with_intf.ml:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/without_intf.ml:4: redefined_unused

./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:2: unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:5: redefined_used
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:2: unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:5: redefined_used

./examples/docs/methods/code_constructs/factory_fun/factory_fun_bin.ml:2: unused_factory

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:2: unused_obj
Expand Down Expand Up @@ -152,6 +165,15 @@
./examples/docs/exported_values/hello_world/hello_world_without_intf.ml:2: hello
./examples/docs/exported_values/hello_world/hello_world_without_intf.ml:3: goodbye

./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/with_intf.mli:5: redefined_used
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/without_intf.mli:5: redefined_used

./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/with_intf.ml:5: redefined_used
./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/without_intf.ml:5: redefined_used

./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:3: used
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:3: used

./examples/docs/fields_and_constructors/code_constructs/extensible_variant/extensible_variant_bin.ml:5: to_string_opt
./examples/docs/fields_and_constructors/code_constructs/extensible_variant/extensible_variant_lib.mli:7: to_string_opt

Expand Down
39 changes: 31 additions & 8 deletions check/threshold-1/threshold-1.ref
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,23 @@

./examples/docs/exported_values/code_constructs/module/module_lib.mli:6: M.unused

./examples/docs/exported_values/limitations/incl_same_name/oo.mli:20: copy: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/oo.mli:25: id: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/oo.mli:40: new_method: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/oo.mli:41: public_method_label: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/with_intf.mli:2: unused: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/with_intf.mli:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/without_intf.ml:2: unused: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/without_intf.mli:4: redefined_unused

./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/with_intf.ml:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/with_intf.mli:2: unused: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/without_intf.ml:2: unused: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/without_intf.ml:4: redefined_unused

./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:2: unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:5: redefined_used
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:2: unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:5: redefined_used

./examples/docs/methods/code_constructs/factory_fun/factory_fun_bin.ml:2: unused_factory

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:2: unused_obj
Expand Down Expand Up @@ -156,6 +169,16 @@
./examples/docs/exported_values/hello_world/hello_world_without_intf.ml:2: hello
./examples/docs/exported_values/hello_world/hello_world_without_intf.ml:3: goodbye

./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/with_intf.mli:3: used: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/with_intf.mli:5: redefined_used
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/without_intf.mli:5: redefined_used

./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/with_intf.ml:5: redefined_used
./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/with_intf.mli:3: used: Should not be detected
./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/without_intf.ml:5: redefined_used

./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:3: used
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:3: used: Not detected
./examples/docs/fields_and_constructors/code_constructs/extensible_variant/extensible_variant_bin.ml:5: to_string_opt
./examples/docs/fields_and_constructors/code_constructs/extensible_variant/extensible_variant_lib.mli:7: to_string_opt

Expand Down Expand Up @@ -1176,7 +1199,7 @@ Nothing else to report in this section
--------------------------------------------------------------------------------


Total: 979
Success: 919
Failed: 60
Ratio: 93.8712972421%
Total: 997
Success: 934
Failed: 63
Ratio: 93.6810431294%
22 changes: 22 additions & 0 deletions check/threshold-3-0.5/threshold-3-0.5.exp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,19 @@

./examples/docs/exported_values/code_constructs/module/module_lib.mli:6: M.unused

./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/with_intf.mli:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/without_intf.mli:4: redefined_unused

./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/with_intf.ml:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/without_intf.ml:4: redefined_unused

./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:2: unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:5: redefined_used
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:2: unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:4: redefined_unused
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:5: redefined_used

./examples/docs/methods/code_constructs/factory_fun/factory_fun_bin.ml:2: unused_factory

./examples/docs/methods/code_constructs/immediate_object/immediate_object_bin.ml:2: unused_obj
Expand Down Expand Up @@ -152,6 +165,15 @@
./examples/docs/exported_values/hello_world/hello_world_without_intf.ml:2: hello
./examples/docs/exported_values/hello_world/hello_world_without_intf.ml:3: goodbye

./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/with_intf.mli:5: redefined_used
./examples/docs/exported_values/limitations/incl_same_name/incl_with_intf/without_intf.mli:5: redefined_used

./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/with_intf.ml:5: redefined_used
./examples/docs/exported_values/limitations/incl_same_name/incl_without_intf/without_intf.ml:5: redefined_used

./examples/docs/exported_values/limitations/incl_same_name/to_incl/with_intf.mli:3: used
./examples/docs/exported_values/limitations/incl_same_name/to_incl/without_intf.ml:3: used

./examples/docs/fields_and_constructors/code_constructs/extensible_variant/extensible_variant_bin.ml:5: to_string_opt
./examples/docs/fields_and_constructors/code_constructs/extensible_variant/extensible_variant_lib.mli:7: to_string_opt

Expand Down
Loading
Loading