Improve incl_same_name - #93
Open
fantazio wants to merge 1 commit into
Open
Conversation
The test was very trivial, only relying on `Stdlib.Oo`. It has been enhanced to be self sustainable and expose the behavior for cases with and without a .mli for the original module and for the new module. `Oo` is now redundant with the more complete tests. Thus, it is removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
examples/docs/exported_values/incl_same_namewas only testing a simple case, corresponding to #55 (withOoinstead ofList).This PR extends the test to more cases:
include module type ofif it does),The use of
Oois now redundant. Thus, it is removed.The
to_inclsubdirectory contains the "original" modules, with and without .mli. Theincl_{with|without}_intfdefine new modules, with and without .mli, which include and are name the same as the original ones.