Conversation
Affie
added
serialization
refactor
breaking change
standardization
StateType
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1207 +/- ##
===========================================
+ Coverage 72.05% 72.37% +0.32%
===========================================
Files 37 37
Lines 2315 2360 +45
===========================================
+ Hits 1668 1708 +40
- Misses 647 652 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Refactors how variable state/belief data is represented and serialized, moving from legacy State.val/State.bw-style storage to a unified BeliefRepresentation that round-trips cleanly through JSON.
Changes:
- Introduces
BeliefRepresentationand embeds it intoStatefor unified parametric/nonparametric belief storage and JSON serialization. - Updates serialization/deserialization helpers (
StateSerialization,PackedSerialization, JSON style overrides) to support the new structures. - Updates and adds tests to validate variable/state/belief JSON round-trips and aligns existing graph tests with
FactorDFG/new state APIs.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| test/testSerializingVariables.jl | Adds round-trip JSON tests for beliefs, states, and variables. |
| test/runtests.jl | Includes the new serialization testset. |
| test/testBlocks.jl | Updates tests to use FactorDFG and revises connectivityTestGraph plumbing. |
| test/consol_DataEntryBlobTests.jl | Updates connectivityTestGraph call signature. |
| test/compareTests.jl | Updates tests to use refPoints(...) instead of removed State.val. |
| test/GraphsDFGSummaryTypes.jl | Refactors summary-type tests to construct from full variable/factor instances. |
| src/entities/DFGVariable.jl | Adds BeliefRepresentation; refactors State and VariableDFG to use belief/statekind. |
| src/serialization/StateSerialization.jl | Adds statekind lower/lift; updates old-state unpacking toward new belief representation. |
| src/serialization/DFGStructStyles.jl | Adds JSON style hooks for StaticArrays/ArrayPartition. |
| src/serialization/PackedSerialization.jl | Minor type signature tweak for resolveType. |
| src/services/CompareUtils.jl | Updates state comparisons and skip logic to use belief fields. |
| src/services/CustomPrinting.jl | Updates printing to use belief fields (points/bandwidth). |
| src/services/DFGVariable.jl | Removes legacy getPoint/getCoordinates implementations. |
| src/DistributedFactorGraphs.jl | Removes packState/unpackState from unstable function list. |
| src/Deprecated.jl | Updates deprecation messaging and re-homes getPoint/getCoordinates as deprecated. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.