Skip to content

refactor(tests): centralize legacy era parametrization #3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkoura merged 1 commit into from
Mar 16, 2026
Merged

refactor(tests): centralize legacy era parametrization #3366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cardano_node_tests/tests/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
MAX_INT64 = (2**63) - 1
MAX_UINT64 = (2**64) - 1

COMPAT_ERAS = ("shelley", "allegra", "mary", "alonzo", "babbage")

ADDR_ALPHABET = string.ascii_lowercase + string.digits

ORDER5_BYRON = (
Expand Down Expand Up @@ -156,6 +158,8 @@
ids=("plutus_v2", "plutus_v3"),
)

PARAM_COMPAT_ERAS = pytest.mark.parametrize("era", COMPAT_ERAS)


# Intervals for `wait_for_epoch_interval` (negative values are counted from the end of an epoch)
if cluster_nodes.get_cluster_type().type == cluster_nodes.ClusterType.LOCAL:
Expand Down
2 changes: 1 addition & 1 deletion cardano_node_tests/tests/test_addr_registration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,7 @@ def _submit_tx(
raise ValueError(err)

@allure.link(helpers.get_vcs_link())
@pytest.mark.parametrize("era", ("shelley", "allegra", "mary", "alonzo", "babbage"))
@common.PARAM_COMPAT_ERAS
@pytest.mark.testnets
@pytest.mark.smoke
def test_legacy_stake_addr_registration_rejected_in_conway(
Expand Down
2 changes: 1 addition & 1 deletion cardano_node_tests/tests/test_delegation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1320,7 +1320,7 @@ def test_delegatee_not_registered(
), exc_value

@allure.link(helpers.get_vcs_link())
@pytest.mark.parametrize("era", ("shelley", "allegra", "mary", "alonzo", "babbage"))
@common.PARAM_COMPAT_ERAS
@pytest.mark.testnets
@pytest.mark.smoke
def test_legacy_stake_delegation_rejected_in_conway(
Expand Down
2 changes: 1 addition & 1 deletion cardano_node_tests/tests/test_pools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2610,7 +2610,7 @@ def test_stake_pool_long_metadata_url(
)

@allure.link(helpers.get_vcs_link())
@pytest.mark.parametrize("era", ("shelley", "allegra", "mary", "alonzo", "babbage"))
@common.PARAM_COMPAT_ERAS
@pytest.mark.testnets
@pytest.mark.smoke
def test_legacy_pool_registration_rejected_in_conway(
Expand Down
2 changes: 1 addition & 1 deletion cardano_node_tests/tests/tests_conway/test_conway.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def test_ratify_state_fields(self, cluster: clusterlib.ClusterLib):

class TestNegativeLegacyGovernance:
@allure.link(helpers.get_vcs_link())
@pytest.mark.parametrize("era", ("shelley", "allegra", "mary", "alonzo", "babbage"))
@common.PARAM_COMPAT_ERAS
@pytest.mark.smoke
def test_mixed_legacy_govaction_and_conway_vote_cert_fails(
self,
Expand Down
2 changes: 1 addition & 1 deletion cardano_node_tests/tests/tests_conway/test_pparam_update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1462,7 +1462,7 @@ class TestLegacyProposals:

@allure.link(helpers.get_vcs_link())
@submit_utils.PARAM_SUBMIT_METHOD
@pytest.mark.parametrize("era", ("shelley", "allegra", "mary", "alonzo", "babbage"))
@common.PARAM_COMPAT_ERAS
@pytest.mark.smoke
def test_legacy_proposal_submit(
self,
Expand Down
2 changes: 1 addition & 1 deletion cardano_node_tests/tests/tests_conway/test_treasury_withdrawals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,7 +736,7 @@ def payment_addr(self, cluster_manager, cluster):
)

@allure.link(helpers.get_vcs_link())
@pytest.mark.parametrize("era", ("shelley", "allegra", "mary", "alonzo", "babbage"))
@common.PARAM_COMPAT_ERAS
@pytest.mark.parametrize(
"mir_cert",
("to_treasury", "to_rewards", "treasury_to_addr", "reserves_to_addr"),
Expand Down
Loading