refactor(tests): centralize legacy era parametrization#3366
Merged
Conversation
Move the list of legacy eras ("shelley", "allegra", "mary", "alonzo", "babbage") to a single constant and parametrize marker (`PARAM_COMPAT_ERAS`) in `common.py`. Update all test files to use the new shared marker for era parametrization, improving maintainability and reducing duplication.
Contributor
There was a problem hiding this comment.
Pull request overview
Centralizes the list of legacy eras and reuses a shared pytest parametrization marker across tests to reduce duplication and simplify future updates.
Changes:
- Add
COMPAT_ERASandPARAM_COMPAT_ERAStotests/common.py. - Replace repeated
@pytest.mark.parametrize("era", (...))usage with@common.PARAM_COMPAT_ERASacross multiple test modules.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cardano_node_tests/tests/common.py | Introduces a shared legacy-era tuple and a reusable pytest parametrization decorator. |
| cardano_node_tests/tests/tests_conway/test_treasury_withdrawals.py | Switches era parametrization to the shared common marker. |
| cardano_node_tests/tests/tests_conway/test_pparam_update.py | Switches era parametrization to the shared common marker. |
| cardano_node_tests/tests/tests_conway/test_conway.py | Switches era parametrization to the shared common marker. |
| cardano_node_tests/tests/test_pools.py | Switches era parametrization to the shared common marker. |
| cardano_node_tests/tests/test_delegation.py | Switches era parametrization to the shared common marker. |
| cardano_node_tests/tests/test_addr_registration.py | Switches era parametrization to the shared common marker. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the list of legacy eras ("shelley", "allegra", "mary", "alonzo", "babbage") to a single constant and parametrize marker (
PARAM_COMPAT_ERAS) incommon.py. Update all test files to use the new shared marker for era parametrization, improving maintainability and reducing duplication.