CI: add a zlib leg to extensions job#700
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds zlib support to the CI/devcontainer environment and extends the existing “extensions” CI job to compile and run the full test suite against the zlib-enabled build variant, ensuring the DEFLATE builtins are exercised in CI.
Changes:
- Install
zlib1g-devin the shared dev/CI container image so zlib headers are available. - Add a
make zlibbuild step in theextensionsjob. - Run the full test suite against the zlib build variant (covering DEFLATE section [124]).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/ci.yml | Adds a zlib build + full-suite leg to the existing extensions CI job. |
| .devcontainer/Dockerfile | Adds zlib1g-dev to the shared dev/CI image so make zlib can compile. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
34
to
38
| git \ | ||
| libpq-dev \ | ||
| zlib1g-dev \ | ||
| postgresql-client \ | ||
| python3 \ |
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reland of #699 by @Haven-Maple (their first contribution — authorship preserved on the commit) from an origin branch so the dev-image job rebuilds from the updated Dockerfile.
The original fork PR's CI was fully green except the new
make zlibleg, which failed withfatal error: zlib.h: No such file or directory. That is the documented fork-PR image-bootstrap constraint: fork PRs run inside the rollingci-mainbase image and cannot publish an image rebuilt from their own Dockerfile, so the freshly addedzlib1g-devnever lands in the image the leg builds against. From an origin branch thebuild dev/ci imagejob rebuilds from this PR's Dockerfile, so the zlib headers are present and the leg can pass.Original PR: #699
Summary
zlib1g-devto the shared dev/CI image.Closes #699
Co-Authored-By: Haven Maple xjk2182738284@gmail.com