Skip to content

CI: add a zlib leg to extensions job#699

Closed
Haven-Maple wants to merge 1 commit into
InauguralSystems:mainfrom
Haven-Maple:ci/zlib-extensions
Closed

CI: add a zlib leg to extensions job#699
Haven-Maple wants to merge 1 commit into
InauguralSystems:mainfrom
Haven-Maple:ci/zlib-extensions

Conversation

@Haven-Maple

Copy link
Copy Markdown
Contributor

Summary

  • Add zlib1g-dev to the shared dev/CI image.
  • Build the zlib variant and run the full suite in the extensions job.

Testing

  • make zlib
  • cd tests && bash run_all_tests.sh
    • 3204/3204 passed
    • DEFLATE Codecs: 22 checks passed

@InauguralPhysicist

Copy link
Copy Markdown
Collaborator

Thanks so much for this, @Haven-Maple — and welcome! 🎉 This is a genuinely well-targeted first contribution: it closes a real gap by giving the DEFLATE builtins (#684/#693) full-suite CI coverage instead of just the minimal-build stub check. I read through the whole diff and verified it against main — the make zlib target, the DEFLATE section [124], and the scope gate all line up, and zlib1g-dev lands in exactly the image the extensions job builds against.

Your PR was a first-time contribution, so CI was held for approval — I've approved it and the full matrix (macOS, tsan, valgrind, plus the new zlib leg) is running now. Assuming it comes back green, this is good to merge as-is.

If you're enjoying EigenScript, a ⭐ on the repo would mean a lot and helps other people find the project. Hope to see more from you!

@InauguralPhysicist

Copy link
Copy Markdown
Collaborator

Shipped! 🚀 Your change is now on main in ba9b335, with your authorship preserved.

Quick note on why this shows as closed-via-#700 rather than merged directly: your PR was completely correct — every CI leg passed except the new make zlib step, which hit a fork-PR bootstrap quirk. Fork PRs run inside our rolling base CI image and can't publish a new image built from their own Dockerfile, so the zlib1g-dev you correctly added never made it into the image that leg built against (zlib.h: No such file or directory). Relanding the identical commit from an internal branch let the CI image rebuild with your Dockerfile change, and then the full zlib leg — DEFLATE section [124], all 22 checks — went green.

So: nothing to fix on your end, this was purely a CI-plumbing constraint on fork PRs. Really nice first contribution, and thank you again — hope to see you back in the tracker! ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants