CI: add a zlib leg to extensions job#699
Conversation
|
Thanks so much for this, @Haven-Maple — and welcome! 🎉 This is a genuinely well-targeted first contribution: it closes a real gap by giving the DEFLATE builtins (#684/#693) full-suite CI coverage instead of just the minimal-build stub check. I read through the whole diff and verified it against Your PR was a first-time contribution, so CI was held for approval — I've approved it and the full matrix (macOS, tsan, valgrind, plus the new zlib leg) is running now. Assuming it comes back green, this is good to merge as-is. If you're enjoying EigenScript, a ⭐ on the repo would mean a lot and helps other people find the project. Hope to see more from you! |
|
Shipped! 🚀 Your change is now on Quick note on why this shows as closed-via-#700 rather than merged directly: your PR was completely correct — every CI leg passed except the new So: nothing to fix on your end, this was purely a CI-plumbing constraint on fork PRs. Really nice first contribution, and thank you again — hope to see you back in the tracker! ⭐ |
Summary
zlib1g-devto the shared dev/CI image.Testing
make zlibcd tests && bash run_all_tests.sh3204/3204 passedDEFLATE Codecs: 22 checks passed