Skip to content

fix(ctaArea): resolve root relative hrefs #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dobromirts wants to merge 1 commit into
base: vnext
Choose a base branch
from
Open

fix(ctaArea): resolve root relative hrefs #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/xplat/src/content/en/components/grids/grids-header.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ Seamlessly scroll through unlimited rows and columns in your {Platform} grid, wi
title="Quick and Easy to Customize, Build and Implement"
description="The Ignite UI {Platform} Data Grid can handle unlimited rows and columns of data, while providing access to custom templates and real-time data updates. Featuring an intuitive API for easy theming and branding, you can quickly bind to data with minimal code."
label="View Samples"
href="data-grid.md"
href="data-grid"
/>

<Feature
Expand Down
2 changes: 1 addition & 1 deletion docs/xplat/src/content/jp/components/grids/grids-header.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ h3#excel-library-for-the-angular-grid ~ h3{
title="Quick and Easy to Customize, Build and Implement"
description="The Ignite UI {Platform} Data Grid can handle unlimited rows and columns of data, while providing access to custom templates and real-time data updates. Featuring an intuitive API for easy theming and branding, you can quickly bind to data with minimal code."
label="View Samples"
href="data-grid.md"
href="data-grid"
/>
<hr style="border: .5px solid #ccc;" />
<igc-divider></igc-divider>
Expand Down
7 changes: 6 additions & 1 deletion src/components/mdx/CtaArea/CtaArea.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ interface Props {

const { title, description, label, href, note, logo = true, variant = 'default', backgroundImage, overlay } = Astro.props;

const base = import.meta.env.BASE_URL.replace(/\/$/, '');
const resolvedHref = href.startsWith('/') && !href.startsWith('//')
? `${base}${href}`
: href;

const resolvedLogo = logo === true ? logoUrl : (typeof logo === 'string' ? logo : null);
const isHorizontal = variant === 'horizontal';

Expand Down Expand Up @@ -60,7 +65,7 @@ const overlayColor = typeof overlay === 'string' ? overlay : undefined;
{description && <p class="cta-area__description">{description}</p>}
</div>
<div class="cta-area__action">
<a class="cta-area__btn no-external-icon" href={href}>{label}</a>
<a class="cta-area__btn no-external-icon" href={resolvedHref}>{label}</a>
{note && <p class="cta-area__note">{note}</p>}
</div>
</div>
Expand Down
Loading