Skip to content

fix(ctaArea): resolve root relative hrefs#348

Open
dobromirts wants to merge 1 commit into
vnextfrom
dtsvetkov/fix-cta-area-hrefs
Open

fix(ctaArea): resolve root relative hrefs#348
dobromirts wants to merge 1 commit into
vnextfrom
dtsvetkov/fix-cta-area-hrefs

Conversation

@dobromirts

Copy link
Copy Markdown
Contributor

Closes #342

  1. CtaArea.astro: prepend import.meta.env.BASE_URL to root-relative hrefs (starting with /) so links like /grid/grid resolve under the site base path on staging/prod instead of the domain root
  2. en/ + jp/ grids-header.mdx: remove .md extension from href="data-grid.md"

@dobromirts

Copy link
Copy Markdown
Contributor Author

@ChronosSF the state has been restored to match the original DocFX reference. IMO the ctaArea (CTA action) should direct users to the platform marketing page instead of linking to a relative page
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

View samples button in marketing section leads to incorrect content

2 participants